Remove enableBridgelessArchitecture flag and global.RN$Bridgeless checks - RFC (#57055)

Summary:
Pull Request resolved: #57055

Changelog: [General][Breaking] Remove enableBridgelessArchitecture flag and global.RN$Bridgeless checks

Differential Revision: D107314734

Author: christophpurrer

packages/react-native/Libraries/Animated/shouldUseTurboAnimatedModule.js

@@ -15,7 +15,7 @@ function shouldUseTurboAnimatedModule(): boolean {
   if (ReactNativeFeatureFlags.cxxNativeAnimatedEnabled()) {
     return false;
   } else {
-    return Platform.OS === 'ios' && global.RN$Bridgeless === true;
+    return Platform.OS === 'ios';
   }
 }
 

packages/react-native/Libraries/BatchedBridge/MessageQueue.js

@@ -417,12 +417,9 @@ class MessageQueue {
           const n = callableModuleNames.length;
           const callableModuleNameList = callableModuleNames.join(', ');
 
-          // TODO(T122225939): Remove after investigation: Why are we getting to this line in bridgeless mode?
-          const isBridgelessMode =
-            global.RN$Bridgeless === true ? 'true' : 'false';
           invariant(
             false,
-            `Failed to call into JavaScript module method ${module}.${method}(). Module has not been registered as callable. Bridgeless Mode: ${isBridgelessMode}. Registered callable JavaScript modules (n = ${n}): ${callableModuleNameList}.
+            `Failed to call into JavaScript module method ${module}.${method}(). Module has not been registered as callable. Registered callable JavaScript modules (n = ${n}): ${callableModuleNameList}.
           A frequent cause of the error is that the application entry file path is incorrect. This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native.`,
           );
         }

packages/react-native/Libraries/Core/registerCallableModule.js

@@ -16,27 +16,16 @@ type RegisterCallableModule = (
   moduleOrFactory: Module | (void => Module),
 ) => void;
 
-const registerCallableModule: RegisterCallableModule = (function () {
-  if (global.RN$Bridgeless === true) {
-    return (name, moduleOrFactory) => {
-      if (typeof moduleOrFactory === 'function') {
-        global.RN$registerCallableModule(name, moduleOrFactory);
-        return;
-      }
-
-      global.RN$registerCallableModule(name, () => moduleOrFactory);
-    };
+const registerCallableModule: RegisterCallableModule = (
+  name,
+  moduleOrFactory,
+) => {
+  if (typeof moduleOrFactory === 'function') {
+    global.RN$registerCallableModule(name, moduleOrFactory);
+    return;
   }
 
-  const BatchedBridge = require('../BatchedBridge/BatchedBridge').default;
-  return (name, moduleOrFactory) => {
-    if (typeof moduleOrFactory === 'function') {
-      BatchedBridge.registerLazyCallableModule(name, moduleOrFactory);
-      return;
-    }
-
-    BatchedBridge.registerCallableModule(name, moduleOrFactory);
-  };
-})();
+  global.RN$registerCallableModule(name, () => moduleOrFactory);
+};
 
 export default registerCallableModule;

packages/react-native/Libraries/Core/setUpBatchedBridge.js

@@ -13,9 +13,6 @@
 import registerModule from './registerCallableModule';
 
 registerModule('Systrace', () => require('../Performance/Systrace'));
-if (!(global.RN$Bridgeless === true)) {
-  registerModule('JSTimers', () => require('./Timers/JSTimers').default);
-}
 registerModule('RCTLog', () => require('../Utilities/RCTLog').default);
 registerModule(
   'RCTDeviceEventEmitter',

packages/react-native/Libraries/Core/setUpTimers.js

@@ -19,86 +19,40 @@ if (__DEV__) {
 }
 
 // In bridgeless mode, timers are host functions installed from cpp.
-if (global.RN$Bridgeless === true) {
-  // This is the flag that tells React to use `queueMicrotask` to batch state
-  // updates, instead of using the scheduler to schedule a regular task.
-  // We use a global variable because we don't currently have any other
-  // mechanism to pass feature flags from RN to React in OSS.
-  global.RN$enableMicrotasksInReact = true;
-
-  polyfillGlobal(
-    'queueMicrotask',
-    () =>
-      require('../../src/private/webapis/microtasks/specs/NativeMicrotasks')
-        .default.queueMicrotask,
-  );
-
-  // We shim the immediate APIs via `queueMicrotask` to maintain the backward
-  // compatibility.
-  polyfillGlobal(
-    'setImmediate',
-    () => require('./Timers/immediateShim').setImmediate,
-  );
-  polyfillGlobal(
-    'clearImmediate',
-    () => require('./Timers/immediateShim').clearImmediate,
-  );
-
-  polyfillGlobal(
-    'requestIdleCallback',
-    () =>
-      require('../../src/private/webapis/idlecallbacks/specs/NativeIdleCallbacks')
-        .default.requestIdleCallback,
-  );
-
-  polyfillGlobal(
-    'cancelIdleCallback',
-    () =>
-      require('../../src/private/webapis/idlecallbacks/specs/NativeIdleCallbacks')
-        .default.cancelIdleCallback,
-  );
-} else {
-  /**
-   * Set up timers.
-   * You can use this module directly, or just require InitializeCore.
-   */
-  const defineLazyTimer = (
-    name:
-      | 'cancelAnimationFrame'
-      | 'cancelIdleCallback'
-      | 'clearInterval'
-      | 'clearTimeout'
-      | 'requestAnimationFrame'
-      | 'requestIdleCallback'
-      | 'setInterval'
-      | 'setTimeout',
-  ) => {
-    polyfillGlobal(name, () => require('./Timers/JSTimers').default[name]);
-  };
-  defineLazyTimer('setTimeout');
-  defineLazyTimer('clearTimeout');
-  defineLazyTimer('setInterval');
-  defineLazyTimer('clearInterval');
-  defineLazyTimer('requestAnimationFrame');
-  defineLazyTimer('cancelAnimationFrame');
-  defineLazyTimer('requestIdleCallback');
-  defineLazyTimer('cancelIdleCallback');
-
-  // Polyfill it with promise (regardless it's polyfilled or native) otherwise.
-  polyfillGlobal(
-    'queueMicrotask',
-    () => require('./Timers/queueMicrotask.js').default,
-  );
-
-  // When promise was polyfilled hence is queued to the RN microtask queue,
-  // we polyfill the immediate APIs as aliases to the ReactNativeMicrotask APIs.
-  // Note that in bridgeless mode, immediate APIs are installed from cpp.
-  polyfillGlobal(
-    'setImmediate',
-    () => require('./Timers/JSTimers').default.queueReactNativeMicrotask,
-  );
-  polyfillGlobal(
-    'clearImmediate',
-    () => require('./Timers/JSTimers').default.clearReactNativeMicrotask,
-  );
-}
+// This is the flag that tells React to use `queueMicrotask` to batch state
+// updates, instead of using the scheduler to schedule a regular task.
+// We use a global variable because we don't currently have any other
+// mechanism to pass feature flags from RN to React in OSS.
+global.RN$enableMicrotasksInReact = true;
+
+polyfillGlobal(
+  'queueMicrotask',
+  () =>
+    require('../../src/private/webapis/microtasks/specs/NativeMicrotasks')
+      .default.queueMicrotask,
+);
+
+// We shim the immediate APIs via `queueMicrotask` to maintain the backward
+// compatibility.
+polyfillGlobal(
+  'setImmediate',
+  () => require('./Timers/immediateShim').setImmediate,
+);
+polyfillGlobal(
+  'clearImmediate',
+  () => require('./Timers/immediateShim').clearImmediate,
+);
+
+polyfillGlobal(
+  'requestIdleCallback',
+  () =>
+    require('../../src/private/webapis/idlecallbacks/specs/NativeIdleCallbacks')
+      .default.requestIdleCallback,
+);
+
+polyfillGlobal(
+  'cancelIdleCallback',
+  () =>
+    require('../../src/private/webapis/idlecallbacks/specs/NativeIdleCallbacks')
+      .default.cancelIdleCallback,
+);

packages/react-native/Libraries/NativeComponent/NativeComponentRegistry.js

@@ -54,7 +54,7 @@ export function get<Config extends {...}>(
 ): HostComponent<Config> {
   ReactNativeViewConfigRegistry.register(name, () => {
     const {native, verify} = getRuntimeConfig?.(name) ?? {
-      native: !global.RN$Bridgeless,
+      native: false,
       verify: false,
     };
 

packages/react-native/Libraries/ReactNative/UIManager.js

@@ -13,16 +13,14 @@ import type {UIManagerJSInterface} from '../Types/UIManagerJSInterface';
 import {getFabricUIManager} from './FabricUIManager';
 import nullthrows from 'nullthrows';
 
+const UIManagerImpl: UIManagerJSInterface =
+  require('./BridgelessUIManager').default;
+
 function isFabricReactTag(reactTag: number): boolean {
   // React reserves even numbers for Fabric.
   return reactTag % 2 === 0;
 }
 
-const UIManagerImpl: UIManagerJSInterface =
-  global.RN$Bridgeless === true
-    ? require('./BridgelessUIManager').default
-    : require('./PaperUIManager').default;
-
 // $FlowFixMe[cannot-spread-interface]
 const UIManager: UIManagerJSInterface = {
   ...UIManagerImpl,

packages/react-native/Libraries/Text/TextNativeComponent.js

@@ -15,7 +15,6 @@ import type {TextProps} from './TextProps';
 
 import {enablePreparedTextLayout} from '../../src/private/featureflags/ReactNativeFeatureFlags';
 import {createViewConfig} from '../NativeComponent/ViewConfig';
-import UIManager from '../ReactNative/UIManager';
 import createReactNativeComponentClass from '../Renderer/shims/createReactNativeComponentClass';
 
 export type NativeTextProps = Readonly<{
@@ -82,11 +81,9 @@ export const NativeText: HostComponent<NativeTextProps> =
   ) as any;
 
 export const NativeVirtualText: HostComponent<NativeTextProps> =
-  !global.RN$Bridgeless && !UIManager.hasViewManagerConfig('RCTVirtualText')
-    ? NativeText
-    : (createReactNativeComponentClass('RCTVirtualText', () =>
-        createViewConfig(virtualTextViewConfig),
-      ) as any);
+  createReactNativeComponentClass('RCTVirtualText', () =>
+    createViewConfig(virtualTextViewConfig),
+  ) as any;
 
 export const NativeSelectableText: HostComponent<NativeTextProps> =
   enablePreparedTextLayout()

packages/react-native/Libraries/Utilities/__tests__/codegenNativeComponent-test.js

@@ -31,8 +31,6 @@ jest
 describe('codegenNativeComponent', () => {
   beforeEach(() => {
     jest.restoreAllMocks();
-    // $FlowExpectedError[cannot-write]
-    global.RN$Bridgeless = false;
     jest.spyOn(console, 'warn').mockImplementation(() => {});
   });
 
@@ -75,16 +73,7 @@ describe('codegenNativeComponent', () => {
     );
   });
 
-  it('should NOT warn if called directly in BRIDGE mode', () => {
-    // $FlowExpectedError[cannot-write]
-    global.RN$Bridgeless = false;
-    codegenNativeComponent<$FlowFixMe>('ComponentName');
-    expect(console.warn).not.toHaveBeenCalled();
-  });
-
-  it('should warn if called directly in BRIDGELESS mode', () => {
-    // $FlowExpectedError[cannot-write]
-    global.RN$Bridgeless = true;
+  it('should warn if called directly', () => {
     codegenNativeComponent<$FlowFixMe>('ComponentName');
     expect(console.warn).toHaveBeenCalledWith(
       `Codegen didn't run for ComponentName. This will be an error in the future. Make sure you are using @react-native/babel-preset when building your JavaScript code.`,

packages/react-native/Libraries/Utilities/codegenNativeComponent.js

@@ -35,7 +35,7 @@ function codegenNativeComponent<Props extends {...}>(
   componentName: string,
   options?: NativeComponentOptions,
 ): NativeComponentType<Props> {
-  if (global.RN$Bridgeless === true && __DEV__) {
+  if (__DEV__) {
     console.warn(
       `Codegen didn't run for ${componentName}. This will be an error in the future. Make sure you are using @react-native/babel-preset when building your JavaScript code.`,
     );