Skip to content

Commit 6a34c9c

Browse files
bestanderFacebook Github Bot 3
authored andcommitted
Disabled flow in e2e test because it causes memory crashes
Summary: Closes #7620 Differential Revision: D3322029 fbshipit-source-id: e0406770d011956af6b47d15c5b49a68b1b611f5
1 parent 8a201b8 commit 6a34c9c

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

circle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@ test:
4848

4949
override:
5050
# eslint bot
51-
- cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; npm run flow --silent -- check --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" CI_USER=$CIRCLE_PROJECT_USERNAME CI_REPO=$CIRCLE_PROJECT_REPONAME PULL_REQUEST_NUMBER=$CIRCLE_PR_NUMBER node bots/code-analysis-bot.js
51+
# - cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; npm run flow --silent -- check --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" CI_USER=$CIRCLE_PROJECT_USERNAME CI_REPO=$CIRCLE_PROJECT_REPONAME PULL_REQUEST_NUMBER=$CIRCLE_PR_NUMBER node bots/code-analysis-bot.js
5252
# JS tests for dependencies installed with npm3
53-
- npm run flow check
53+
# - npm run flow check
5454
- npm test -- --maxWorkers=1
5555

5656
# build app

scripts/run-ci-e2e-tests.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,12 @@ try {
195195
exitCode = 1;
196196
throw Error(exitCode);
197197
}
198-
if (exec(`${ROOT}/node_modules/.bin/flow check`).code) {
199-
echo('Flow check does not pass');
200-
exitCode = 1;
201-
throw Error(exitCode);
202-
}
198+
// TODO disabled while flow 0.25.0 is crashing
199+
// if (exec(`${ROOT}/node_modules/.bin/flow check`).code) {
200+
// echo('Flow check does not pass');
201+
// exitCode = 1;
202+
// throw Error(exitCode);
203+
// }
203204
}
204205
exitCode = 0;
205206

0 commit comments

Comments
 (0)