Skip to content

Commit 3ccfb58

Browse files
fred2028Facebook Github Bot 4
authored andcommitted
Simplify SwipeableRow styling
Summary: - Removed some styling from `SwipeableRow` that wasn't doing much and made slide out view full height Reviewed By: fkgozali Differential Revision: D3322849 fbshipit-source-id: 811eee9032c142c61d303ae7e966d8ef7903adaf
1 parent 62e588b commit 3ccfb58

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

Libraries/Experimental/SwipeableRow/SwipeableRow.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ const SwipeableRow = React.createClass({
7474
* component A to be transparent until component B is loaded.
7575
*/
7676
isSwipeableViewRendered: false,
77+
rowHeight: (null: ?number),
7778
};
7879
},
7980

@@ -117,7 +118,10 @@ const SwipeableRow = React.createClass({
117118
let slideOutView;
118119
if (this.state.isSwipeableViewRendered) {
119120
slideOutView = (
120-
<View style={styles.slideOutContainer}>
121+
<View style={[
122+
styles.slideOutContainer,
123+
{height: this.state.rowHeight},
124+
]}>
121125
{this.props.slideoutView}
122126
</View>
123127
);
@@ -139,8 +143,7 @@ const SwipeableRow = React.createClass({
139143

140144
return (
141145
<View
142-
{...this._panResponder.panHandlers}
143-
style={styles.container}>
146+
{...this._panResponder.panHandlers}>
144147
{slideOutView}
145148
{swipeableView}
146149
</View>
@@ -151,6 +154,7 @@ const SwipeableRow = React.createClass({
151154
if (!this.state.isSwipeableViewRendered) {
152155
this.setState({
153156
isSwipeableViewRendered: true,
157+
rowHeight: event.nativeEvent.layout.height,
154158
});
155159
}
156160
},
@@ -225,13 +229,8 @@ const SwipeableRow = React.createClass({
225229
});
226230

227231
const styles = StyleSheet.create({
228-
container: {
229-
flex: 1,
230-
flexDirection: 'row',
231-
},
232232
slideOutContainer: {
233233
bottom: 0,
234-
flex: 1,
235234
left: 0,
236235
position: 'absolute',
237236
right: 0,

0 commit comments

Comments
 (0)