Fix accessibilityLabelledBy crash on empty array (#57029)

Summary:

Fixes a crash in `BaseViewManager.setAccessibilityLabelledBy` when an empty array is passed. The method now guards against accessing index 0 on empty arrays and properly clears the tag when null or empty arrays are provided, instead of leaving stale associations.

## Changelog

[Android][Fixed] - Issue when clearing accessibilityLabelledBy

Reviewed By: bvanderhoof

Differential Revision: D107127388

Author: rozele

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

@@ -309,15 +309,17 @@ public void setNativeId(@NonNull T view, @Nullable String nativeId) {
 
   @ReactProp(name = ViewProps.ACCESSIBILITY_LABELLED_BY)
   public void setAccessibilityLabelledBy(@NonNull T view, @Nullable Dynamic nativeId) {
-    if (nativeId.isNull()) {
+    if (nativeId == null || nativeId.isNull()) {
+      view.setTag(R.id.labelled_by, null);
       return;
     }
     if (nativeId.getType() == ReadableType.String) {
       view.setTag(R.id.labelled_by, nativeId.asString());
     } else if (nativeId.getType() == ReadableType.Array) {
       // On Android, this takes a single View as labeledBy. If an array is specified, set the first
       // element in the tag.
-      view.setTag(R.id.labelled_by, nativeId.asArray().getString(0));
+      ReadableArray array = nativeId.asArray();
+      view.setTag(R.id.labelled_by, array.size() > 0 ? array.getString(0) : null);
     }
   }
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/BaseViewManagerTest.kt

@@ -12,6 +12,7 @@ package com.facebook.react.uimanager
 import android.view.View.OnFocusChangeListener
 import com.facebook.react.R
 import com.facebook.react.bridge.BridgeReactContext
+import com.facebook.react.bridge.JavaOnlyArray
 import com.facebook.react.bridge.JavaOnlyMap
 import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
 import com.facebook.react.views.view.ReactViewGroup
@@ -101,4 +102,31 @@ class BaseViewManagerTest {
     verify(originalFocusListener, times(2)).onFocusChange(view, true)
     Assertions.assertThat(originalFocusListener).isEqualTo(view.onFocusChangeListener)
   }
+
+  @Test
+  fun testAccessibilityLabelledByString() {
+    viewManager.setAccessibilityLabelledBy(view, DynamicFromObject("target_id"))
+    Assertions.assertThat(view.getTag(R.id.labelled_by)).isEqualTo("target_id")
+  }
+
+  @Test
+  fun testAccessibilityLabelledByArray() {
+    val array = JavaOnlyArray.of("first_id", "second_id")
+    viewManager.setAccessibilityLabelledBy(view, DynamicFromObject(array))
+    Assertions.assertThat(view.getTag(R.id.labelled_by)).isEqualTo("first_id")
+  }
+
+  @Test
+  fun testAccessibilityLabelledByNullClearsTag() {
+    view.setTag(R.id.labelled_by, "stale_id")
+    viewManager.setAccessibilityLabelledBy(view, DynamicFromObject(null))
+    Assertions.assertThat(view.getTag(R.id.labelled_by)).isNull()
+  }
+
+  @Test
+  fun testAccessibilityLabelledByEmptyArrayDoesNotCrash() {
+    view.setTag(R.id.labelled_by, "stale_id")
+    viewManager.setAccessibilityLabelledBy(view, DynamicFromObject(JavaOnlyArray()))
+    Assertions.assertThat(view.getTag(R.id.labelled_by)).isNull()
+  }
 }