Skip to content

Commit 013e623

Browse files
HuxproLuna Wei
authored andcommitted
Revert the Android specific max heap size GCConfig
Summary: Changelog: [Category][Internal] This diff reverts the [Androids-specific heap size overrides](github.com/facebook/react-native/commit/63d20d3b1ef35cb4398d63d62f631f7f5d2935c7#diff-4c59ddca85e294a90a0e1bd15ed323ff4e130911d9642680dde44aacbcd7d32c) after [Hermes has changed its default max heap size to 3GiB](facebook/hermes@5f2b47d). You can read about more context there. Reviewed By: yungsters Differential Revision: D30726067 fbshipit-source-id: 1bcc93fdf4da817f3b3d60bd09c6a5a64166eb7e
1 parent b4a1d2b commit 013e623

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/HermesExecutorFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class HermesExecutorFactory implements JavaScriptExecutorFactory {
1717
private final RuntimeConfig mConfig;
1818

1919
public HermesExecutorFactory() {
20-
this(new RuntimeConfig(1024));
20+
this(null);
2121
}
2222

2323
public HermesExecutorFactory(RuntimeConfig config) {

ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/RuntimeConfig.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,4 @@
1010
/** Holds runtime configuration for a Hermes VM instance (master or snapshot). */
1111
public final class RuntimeConfig {
1212
public long heapSizeMB;
13-
14-
RuntimeConfig() {}
15-
16-
RuntimeConfig(long heapSizeMB) {
17-
this.heapSizeMB = heapSizeMB;
18-
}
1913
}

0 commit comments

Comments
 (0)