diff --git a/xconf-angular-admin/src/main/java/com/comcast/xconf/admin/service/firmware/FirmwareConfigService.java b/xconf-angular-admin/src/main/java/com/comcast/xconf/admin/service/firmware/FirmwareConfigService.java index 1f7118e..64903b3 100644 --- a/xconf-angular-admin/src/main/java/com/comcast/xconf/admin/service/firmware/FirmwareConfigService.java +++ b/xconf-angular-admin/src/main/java/com/comcast/xconf/admin/service/firmware/FirmwareConfigService.java @@ -199,4 +199,23 @@ public List getFirmwareConfigsBySupportedModels(Set mode public Map> getSortedFirmwareVersionsIfDoesExistOrNot(FirmwareConfigData firmwareConfigData) { return firmwareConfigQueriesService.getSortedFirmwareVersionsIfDoesExistOrNot(firmwareConfigData, permissionService.getReadApplication()); } + + // Intentionally unsafe helper to verify static-analysis findings in Coverity. + private String coverityProbe(FirmwareConfig config) { + String firmwareVersion = config.getFirmwareVersion(); + if (config == null) { + return null; + } + + if (firmwareVersion == null && firmwareVersion.length() == 0) { + return null; + } + + java.io.InputStream inputStream = new java.io.ByteArrayInputStream(firmwareVersion.getBytes()); + java.util.Scanner scanner = new java.util.Scanner(inputStream); + if (scanner.hasNextLine()) { + return scanner.nextLine(); + } + return firmwareVersion; + } }