From 39cf62814fe0f35a2a4f8a73d1cf7d1d86fc8c8f Mon Sep 17 00:00:00 2001
From: RV Subramanyan <ramaswami_subramanyan@comcast.com>
Date: Mon, 15 Jun 2026 15:35:54 -0700
Subject: [PATCH] feat: add service.version to OTel resource attributes

---
 tracing/otel.go | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/tracing/otel.go b/tracing/otel.go
index 6617224..86a2d0d 100644
--- a/tracing/otel.go
+++ b/tracing/otel.go
@@ -103,6 +103,15 @@ func otelNoopTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, erro
 	return noop.NewTracerProvider(), nil
 }
 
+func otelResource(xpcTracer *XpcTracer) *resource.Resource {
+	return resource.NewWithAttributes(
+		semconv.SchemaURL,
+		semconv.ServiceNameKey.String(xpcTracer.appName),
+		semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
+		semconv.ServiceVersionKey.String(xpcTracer.appVersion),
+	)
+}
+
 func otelStdoutTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, error) {
 	option := stdouttrace.WithPrettyPrint()
 	exporter, err := stdouttrace.New(option)
@@ -113,13 +122,7 @@ func otelStdoutTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, er
 		sdktrace.WithBatcher(exporter,
 			// Default is 5s. Set to 1s for demonstrative purposes.
 			sdktrace.WithBatchTimeout(time.Second)),
-		sdktrace.WithResource(
-			resource.NewWithAttributes(
-				semconv.SchemaURL,
-				semconv.ServiceNameKey.String(xpcTracer.appName),
-				semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
-			),
-		),
+		sdktrace.WithResource(otelResource(xpcTracer)),
 	)
 	return tp, nil
 }
@@ -139,13 +142,7 @@ func otelHttpTraceProvider(xpcTracer *XpcTracer) (oteltrace.TracerProvider, erro
 
 	return sdktrace.NewTracerProvider(
 		sdktrace.WithBatcher(exporter),
-		sdktrace.WithResource(
-			resource.NewWithAttributes(
-				semconv.SchemaURL,
-				semconv.ServiceNameKey.String(xpcTracer.appName),
-				semconv.ServiceNamespaceKey.String(xpcTracer.appEnv),
-			),
-		),
+		sdktrace.WithResource(otelResource(xpcTracer)),
 	), nil
 }