From 8d222f2578107a7d38cf87d065e0fa1e61ee2f95 Mon Sep 17 00:00:00 2001 From: Kumar Date: Fri, 10 Jul 2026 15:38:17 +0530 Subject: [PATCH 1/8] removed activate for CEC api --- .../AdvancedSettingsScreen.js | 34 +++++++++---------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js index ea828bb9..1bdb11b8 100644 --- a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js +++ b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js @@ -182,11 +182,11 @@ export default class AdvanceSettingsScreen extends Lightning.Component { _init() { this.cecApi = new CECApi() - this.cecApi.activate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') - this.performOTPAction() - }) + // this.cecApi.activate() + // .then(() => { + // this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') + // this.performOTPAction() + // }) this._setState('TTSOptions') } _focus() { @@ -214,19 +214,17 @@ export default class AdvanceSettingsScreen extends Lightning.Component { toggleCEC() { this.cecApi.getEnabled() .then(res => { - this.LOG("cec getenabled result:" + JSON.stringify(res)) - if (res.enabled) { - this.cecApi.deactivate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOffWhite.png') - }) - } - else { - this.cecApi.activate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') - }) - } + this.LOG("cec getenabled result:" + JSON.stringify(res)) + // get the current state and toggle it + const newEnabledState = !res.enabled + this.cecApi.setEnabled({ enabled: newEnabledState }) + .then(() => { + // Update UI based on new state + const imageSrc = newEnabledState + ? 'images/settings/ToggleOnOrange.png' + : 'images/settings/ToggleOffWhite.png' + this.tag('CECControl.Button').src = Utils.asset(imageSrc) + }) }) } static _states() { From 8f591a011c1a44b83283099bdc50a0490d359ef4 Mon Sep 17 00:00:00 2001 From: Kumar Date: Mon, 13 Jul 2026 15:08:16 +0530 Subject: [PATCH 2/8] added condition for CEC toggle button --- accelerator-home-ui/src/api/CECApi.js | 4 +- .../AdvancedSettingsScreenOverlay.js | 34 ++++++++--------- .../AdvancedSettingsScreen.js | 37 +++++++++++-------- 3 files changed, 40 insertions(+), 35 deletions(-) diff --git a/accelerator-home-ui/src/api/CECApi.js b/accelerator-home-ui/src/api/CECApi.js index 7e730f29..3be4b5cf 100644 --- a/accelerator-home-ui/src/api/CECApi.js +++ b/accelerator-home-ui/src/api/CECApi.js @@ -69,9 +69,9 @@ export default class CECApi { }) } - setEnabled() { + setEnabled(enabled = true) { return new Promise((resolve) => { - thunder.call('org.rdk.HdmiCecSource', 'setEnabled', { enabled: true }) + thunder.call('org.rdk.HdmiCecSource', 'setEnabled', { enabled }) .then(result => { resolve(result) }) diff --git a/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js b/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js index 26d46bc9..ec5656f1 100644 --- a/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js +++ b/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js @@ -174,10 +174,14 @@ _init() { this.cecApi = new CECApi() - this.cecApi.activate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') - this.performOTPAction() + this.cecApi.getEnabled() + .then(res => { + const isEnabled = !!(res && res.enabled) + this.tag('CECControl.Button').src = Utils.asset( + isEnabled + ? 'images/settings/ToggleOnOrange.png' + : 'images/settings/ToggleOffWhite.png' + ) }) this._setState('CECControl') } @@ -185,7 +189,7 @@ this._setState('CECControl') } performOTPAction() { - this.cecApi.setEnabled().then(res => { + this.cecApi.setEnabled(true).then(res => { if (res.success) { this.cecApi.performOTP().then(otpRes => { if (otpRes.success) { @@ -200,18 +204,14 @@ this.cecApi.getEnabled() .then(res => { this.LOG("toggleCEC getEnabled result: " + JSON.stringify(res)) - if (res.enabled) { - this.cecApi.deactivate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOffWhite.png') - }) - } - else { - this.cecApi.activate() - .then(() => { - this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') - }) - } + const newEnabledState = !(res && res.enabled) + this.cecApi.setEnabled(newEnabledState) + .then(() => { + const imageSrc = newEnabledState + ? 'images/settings/ToggleOnOrange.png' + : 'images/settings/ToggleOffWhite.png' + this.tag('CECControl.Button').src = Utils.asset(imageSrc) + }) }) } diff --git a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js index 1bdb11b8..416bd9ef 100644 --- a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js +++ b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js @@ -182,11 +182,16 @@ export default class AdvanceSettingsScreen extends Lightning.Component { _init() { this.cecApi = new CECApi() - // this.cecApi.activate() - // .then(() => { - // this.tag('CECControl.Button').src = Utils.asset('images/settings/ToggleOnOrange.png') - // this.performOTPAction() - // }) + this.cecApi.getEnabled() + .then(res => { + // get the current state of CEC and set the toogle button based on status. + const isEnabled = !!(res && res.enabled) + this.tag('CECControl.Button').src = Utils.asset( + isEnabled + ? 'images/settings/ToggleOnOrange.png' + : 'images/settings/ToggleOffWhite.png' + ) + }) this._setState('TTSOptions') } _focus() { @@ -200,7 +205,7 @@ export default class AdvanceSettingsScreen extends Lightning.Component { } performOTPAction() { - this.cecApi.setEnabled().then(res => { + this.cecApi.setEnabled(true).then(res => { if (res.success) { this.cecApi.performOTP().then(otpRes => { if (otpRes.success) { @@ -214,17 +219,17 @@ export default class AdvanceSettingsScreen extends Lightning.Component { toggleCEC() { this.cecApi.getEnabled() .then(res => { - this.LOG("cec getenabled result:" + JSON.stringify(res)) - // get the current state and toggle it - const newEnabledState = !res.enabled - this.cecApi.setEnabled({ enabled: newEnabledState }) - .then(() => { + this.LOG("cec getenabled result:" + JSON.stringify(res)) + // get the current state and toggle it. + const newEnabledState = !(res && res.enabled) + this.cecApi.setEnabled(newEnabledState) + .then(() => { // Update UI based on new state - const imageSrc = newEnabledState - ? 'images/settings/ToggleOnOrange.png' - : 'images/settings/ToggleOffWhite.png' - this.tag('CECControl.Button').src = Utils.asset(imageSrc) - }) + const imageSrc = newEnabledState + ? 'images/settings/ToggleOnOrange.png' + : 'images/settings/ToggleOffWhite.png' + this.tag('CECControl.Button').src = Utils.asset(imageSrc) + }) }) } static _states() { From 7d6e823e8922472638a7b32820e253ee6dee00ff Mon Sep 17 00:00:00 2001 From: Kumar Date: Mon, 13 Jul 2026 15:48:12 +0530 Subject: [PATCH 3/8] added perform otp in initState --- .../OtherSettings/AdvancedSettingsScreenOverlay.js | 13 ++++++++++++- .../OtherSettingsScreens/AdvancedSettingsScreen.js | 6 ++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js b/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js index ec5656f1..f23a0466 100644 --- a/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js +++ b/accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js @@ -182,6 +182,9 @@ ? 'images/settings/ToggleOnOrange.png' : 'images/settings/ToggleOffWhite.png' ) + if (isEnabled) { + this.performOTPAction() + } }) this._setState('CECControl') } @@ -206,11 +209,19 @@ this.LOG("toggleCEC getEnabled result: " + JSON.stringify(res)) const newEnabledState = !(res && res.enabled) this.cecApi.setEnabled(newEnabledState) - .then(() => { + .then(setRes => { + if (!(setRes && setRes.success)) { + this.WARN('CEC setEnabled failed: ' + JSON.stringify(setRes)) + return + } const imageSrc = newEnabledState ? 'images/settings/ToggleOnOrange.png' : 'images/settings/ToggleOffWhite.png' this.tag('CECControl.Button').src = Utils.asset(imageSrc) + + if (newEnabledState) { + this.performOTPAction() + } }) }) } diff --git a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js index 416bd9ef..215a33e0 100644 --- a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js +++ b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js @@ -191,6 +191,9 @@ export default class AdvanceSettingsScreen extends Lightning.Component { ? 'images/settings/ToggleOnOrange.png' : 'images/settings/ToggleOffWhite.png' ) + if (isEnabled) { + this.performOTPAction() + } }) this._setState('TTSOptions') } @@ -229,6 +232,9 @@ export default class AdvanceSettingsScreen extends Lightning.Component { ? 'images/settings/ToggleOnOrange.png' : 'images/settings/ToggleOffWhite.png' this.tag('CECControl.Button').src = Utils.asset(imageSrc) + if (newEnabledState) { + this.performOTPAction() + } }) }) } From 99137f89e30871f299cdc3028685643e5fa75e30 Mon Sep 17 00:00:00 2001 From: Sudarsanan Kumar Date: Mon, 13 Jul 2026 15:49:05 +0530 Subject: [PATCH 4/8] changed toggle spelling Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .../src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js index 215a33e0..e42941d8 100644 --- a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js +++ b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js @@ -184,7 +184,7 @@ export default class AdvanceSettingsScreen extends Lightning.Component { this.cecApi = new CECApi() this.cecApi.getEnabled() .then(res => { - // get the current state of CEC and set the toogle button based on status. + // get the current state of CEC and set the toggle button based on status. const isEnabled = !!(res && res.enabled) this.tag('CECControl.Button').src = Utils.asset( isEnabled From 68fb27a1e532bbbcb100d8e69304deca13915e37 Mon Sep 17 00:00:00 2001 From: Kumar Date: Tue, 14 Jul 2026 15:38:13 +0530 Subject: [PATCH 5/8] added logs --- .../src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js index 215a33e0..a4ee01f9 100644 --- a/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js +++ b/accelerator-home-ui/src/screens/OtherSettingsScreens/AdvancedSettingsScreen.js @@ -186,6 +186,8 @@ export default class AdvanceSettingsScreen extends Lightning.Component { .then(res => { // get the current state of CEC and set the toogle button based on status. const isEnabled = !!(res && res.enabled) + console.log(`CEC initial status: ${isEnabled}`) + this.tag('CECControl.Button').src = Utils.asset( isEnabled ? 'images/settings/ToggleOnOrange.png' From 8fedff394739131e7dd4587d160017f4dbb18114 Mon Sep 17 00:00:00 2001 From: SudarsananComcast Date: Wed, 15 Jul 2026 17:22:53 +0530 Subject: [PATCH 6/8] version changed --- accelerator-home-ui/settings.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accelerator-home-ui/settings.json b/accelerator-home-ui/settings.json index 2d334d00..a0d036b6 100644 --- a/accelerator-home-ui/settings.json +++ b/accelerator-home-ui/settings.json @@ -13,6 +13,6 @@ "log": true, "enableAppSuspended": true, "showVersion": false, - "version": "6.0.27" + "version": "6.0.28" } } From bfb6357fa507f9029bb4a9ef1bf542104a27584d Mon Sep 17 00:00:00 2001 From: SudarsananComcast Date: Wed, 15 Jul 2026 17:23:08 +0530 Subject: [PATCH 7/8] version changed --- bolt/package-configs/com.rdkcentral.refui.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bolt/package-configs/com.rdkcentral.refui.json b/bolt/package-configs/com.rdkcentral.refui.json index 1279f945..5ccfa2ac 100644 --- a/bolt/package-configs/com.rdkcentral.refui.json +++ b/bolt/package-configs/com.rdkcentral.refui.json @@ -1,7 +1,7 @@ { "id": "com.rdkcentral.refui", - "version": "6.0.27", - "versionName": "6.0.27", + "version": "6.0.28", + "versionName": "6.0.28", "name": "RDK Ref UI Home Screen", "packageType": "application", "entryPoint": "--lightning --dev file:///usr/share/refui/index.html", From 38c4be4528206936d86628050cae9dc12bf8ddf1 Mon Sep 17 00:00:00 2001 From: SudarsananComcast Date: Fri, 17 Jul 2026 16:32:51 +0530 Subject: [PATCH 8/8] removed activated for CEC Api --- accelerator-home-ui/src/App.js | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/accelerator-home-ui/src/App.js b/accelerator-home-ui/src/App.js index 55aef49e..ac89ab59 100644 --- a/accelerator-home-ui/src/App.js +++ b/accelerator-home-ui/src/App.js @@ -780,30 +780,7 @@ export default class App extends Router.App { this.LOG("App getActiveSourceStatus: " + JSON.stringify(res) + " UICacheCECActiveSourceStatus:" + JSON.stringify(Storage.get("UICacheCECActiveSourceStatus"))); }); } else { - cecApi.activate().then(() => { - let getfriendlyname, getosdname; - setTimeout(() => { - appApi.getFriendlyName().then(res => { - getfriendlyname = res.friendlyName; - this.LOG("AppApi getFriendlyName :" + JSON.stringify(getfriendlyname)); - }).catch(err => { - this.ERR("AppApi getFriendlyName Error: " + JSON.stringify(err)); - }) - cecApi.getOSDName().then(result => { - getosdname = result.name; - this.LOG("CECApi getOSDName :" + JSON.stringify(getosdname)); - if (getfriendlyname !== getosdname) { - cecApi.setOSDName(getfriendlyname); - } - }).catch(err => { - this.ERR("CECApi getOSDName Error :" + JSON.stringify(err)); - }) - }, 5000); - cecApi.getActiveSourceStatus().then((res) => { - Storage.set("UICacheCECActiveSourceStatus", res); - this.LOG("App getActiveSourceStatus: " + JSON.stringify(res) + " UICacheCECActiveSourceStatus:" + JSON.stringify(Storage.get("UICacheCECActiveSourceStatus"))); - }); - }).catch((err) => this.ERR(JSON.stringify(err))) + this.LOG('HdmiCecSource is inactive during boot; leaving it disabled until the user enables it from the UI') } }) this._subscribeToIOPortNotifications()