From 8208d25cd2049ebdfc177a5b3d7608367a523b96 Mon Sep 17 00:00:00 2001 From: OMSociety <85862362+OMSociety@users.noreply.github.com> Date: Sat, 14 Nov 2026 02:12:17 +0800 Subject: [PATCH 1/3] fix(web): bind color-scheme on the OS-driven dark palette The OS-driven dark block supplied the dark CSS vars but left `color-scheme` at the base `light dark`, which resolves to light when the OS asks for neither scheme. Native control chrome is painted from `color-scheme`, not from the vars, so the compress prompt-pack 's option popup, checkbox/radio glyphs, scrollbars. The base + // :root carries `light dark` (#2473, canvas/ground coupling), but the + // BASE value resolves to `light` whenever the OS asks for neither scheme, + // so each dark palette rebinds it to dark — otherwise the compress + // prompt-pack 's option popup, checkbox/radio glyphs, scrollbars. The base // :root carries `light dark` (#2473, canvas/ground coupling), but the From 7558ee7e37e6e327b789180aa4660e0e4f96991a Mon Sep 17 00:00:00 2001 From: ci-check Date: Sat, 14 Nov 2026 21:11:15 +0800 Subject: [PATCH 3/3] fix: cite the correct issue (#6587, not #6588) for the color-scheme fix --- src/web/styles.ts | 2 +- tests/dsh-settings-ui.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/web/styles.ts b/src/web/styles.ts index 409a9333ca..183c8068ad 100644 --- a/src/web/styles.ts +++ b/src/web/styles.ts @@ -58,7 +58,7 @@ export const WEB_STYLES = String.raw` signal, so the media query below is narrowed to documents WITHOUT one; the pinned palette repeats the same list (CSS cannot share declarations across media boundaries — keep the two lists in sync). - #6588: each dark palette declares color-scheme: dark. The UA paints native + #6587: each dark palette declares color-scheme: dark. The UA paints native control chrome (a select's option popup, checkbox/radio glyphs, scrollbars) from color-scheme rather than from the CSS vars, so the declaration keeps those controls on the dark ground the palette establishes. */ diff --git a/tests/dsh-settings-ui.test.ts b/tests/dsh-settings-ui.test.ts index c73c4ef180..6c8ac47268 100644 --- a/tests/dsh-settings-ui.test.ts +++ b/tests/dsh-settings-ui.test.ts @@ -2261,7 +2261,7 @@ test("#4406: the Context tab marks the conversation scroll container and hides t assert.equal(scrollAttrs.has("data-bili-surface"), false, "leaving the tab drops the marker"); }); -test("#6588: both dark palettes bind color-scheme so native controls follow the theme", () => { +test("#6587: both dark palettes bind color-scheme so native controls follow the theme", () => { // `color-scheme` is what the UA paints native control chrome from: a //