From 439adf8175f90fc3ab5c4881071f49f59a8bdd7b Mon Sep 17 00:00:00 2001 From: awork Date: Fri, 23 Oct 2026 12:59:24 +0800 Subject: [PATCH 1/2] docs(tests): correct stale storage-default comment in preload-storage-baseline (#4011 review) The header claimed the production default was still "shadow" (the interim #2815-era value). Since #3818 the default is "full", which made the comment mislead test authors about what the legacy baseline actually overrides. Add the lesson from PR #4011: suites whose assertions depend on a specific storage mode must pin BILI_STORAGE_UNIFIED themselves, because this baseline overrides the production default in CI. --- tests/preload-storage-baseline.mjs | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/preload-storage-baseline.mjs b/tests/preload-storage-baseline.mjs index 0488191517..75e13daa7c 100644 --- a/tests/preload-storage-baseline.mjs +++ b/tests/preload-storage-baseline.mjs @@ -1,12 +1,15 @@ // Global test-runner baseline for the unified-storage mode (#2815 rollout). // -// resolveStorageMode() now defaults to "shadow" when neither the env nor the -// config file says anything (production default flip). The broad wire/e2e -// corpus, though, was written against the legacy default: hundreds of suites -// build SessionStores in mkdtemp dirs and rmSync them without SQLite handle -// choreography (Windows EPERM territory) and some assert index.db absence -// incidentally. Keep that corpus on an explicit legacy baseline; the storage -// family (tests/storage-*.test.ts, tests/identity-registry.test.ts, +// resolveStorageMode() defaults to "full" when neither the env nor the config +// file says anything (#3818 production default flip; the interim #2815-era +// default was "shadow"). The broad wire/e2e corpus, though, was written +// against the legacy default: hundreds of suites build SessionStores in +// mkdtemp dirs and rmSync them without SQLite handle choreography (Windows +// EPERM territory) and some assert index.db absence incidentally. Keep that +// corpus on an explicit legacy baseline; any suite whose assertions depend on +// a specific storage mode MUST pin BILI_STORAGE_UNIFIED itself — relying on +// the production default passes locally but breaks here (#4011 lesson). The +// storage family (tests/storage-*.test.ts, tests/identity-registry.test.ts, // tests/bounded-storage*.test.ts, tests/export-jsonl.test.ts, // tests/e2e/e2e-sqlite-bootstrap.test.ts) pins and overrides its own modes, // and the default's own semantics are covered by the resolveStorageMode From dfadc21b339bfa45c6ec03b2f13e723ce6bf0507 Mon Sep 17 00:00:00 2001 From: ci-check Date: Mon, 26 Oct 2026 15:22:50 +0800 Subject: [PATCH 2/2] fix(ci): sync lockfile recorded versions with acp-kernel 0.0.165 (#4599) master window commits 293ae6542/de5e03659 bumped kernel/package.json to 0.0.165 without regenerating the lockfiles; lock-sync re-resolution then rewrites the stale recorded versions (root 0.0.163, kernel 0.0.164) and fails. Pure recorded-version sync via npm install --package-lock-only; no dependency or semantic change. --- kernel/package-lock.json | 4 ++-- package-lock.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/package-lock.json b/kernel/package-lock.json index da011d94e1..4c5e2d79e9 100644 --- a/kernel/package-lock.json +++ b/kernel/package-lock.json @@ -1,12 +1,12 @@ { "name": "acp-kernel", - "version": "0.0.164", + "version": "0.0.165", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "acp-kernel", - "version": "0.0.164", + "version": "0.0.165", "license": "MIT", "devDependencies": { "@types/node": "^22.0.0", diff --git a/package-lock.json b/package-lock.json index 380212c96e..15a6e3f4e9 100644 --- a/package-lock.json +++ b/package-lock.json @@ -50,7 +50,7 @@ }, "kernel": { "name": "acp-kernel", - "version": "0.0.163", + "version": "0.0.165", "dev": true, "license": "MIT", "devDependencies": {