From 765959b4b49b4bac467d7c34da30d24ace5a9363 Mon Sep 17 00:00:00 2001 From: ranxianglei Date: Thu, 15 Oct 2026 09:33:04 +0800 Subject: [PATCH] =?UTF-8?q?ci:=20run=20the=20test=20matrix=20on=20master?= =?UTF-8?q?=20pushes=20=E2=80=94=20skipped=20guards=20no=20longer=20cascad?= =?UTF-8?q?e-skip=20the=20legs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test job needs 9 guards; 4 are pull_request-only (version/kernel/ pi-subagents/lane-guard). A skipped need cascades the skip to dependents (GitHub-documented behavior) — the workflow comment's 'skipped needs count as satisfied' never held. Result: every master push ran CI with 'test: skipped' (e.g. run 38665531939), so master has had NO post-merge unit-test signal — the hole that let #3145 (port collisions), #3027 (golden drift) and #3035 slip red to master unnoticed. Fix: explicit 'if: !failure() && !cancelled()' on the test job: - pull_request: guards run; a guard failure still skips the legs (required checks pending, merge blocked — #2637 fail-fast tiering intact) - push/dispatch: PR-only guards skip harmlessly, the 12 shard legs RUN and master gets a real post-merge signal Cost: bounded by the existing per-ref concurrency cancel (owner-approved 2026-10-10) — rapid merge sequences only pay for the last push. --- .github/workflows/ci.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 663ab42562..f133c49948 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,8 +35,18 @@ jobs: # #2637 plan #8 (owner-approved): fail-fast tiering — the ~0-1m guards gate # the four platform legs so a broken commit stops in tier 1 instead of # paying 4x(install+typecheck+suites+build). Guards with `if: pull_request` - # skip on push/dispatch (skipped needs count as satisfied). Behavior change: - # on guard failure the required legs show pending (not red); merge blocked. + # skip on push/dispatch — and a SKIPPED need cascades the skip to dependents + # (the GitHub-documented behavior; the old comment here wrongly assumed + # "skipped needs count as satisfied" — the master-push run evidence + # (#3145/#3035/#3027 all slipped red to master with `test: skipped`) + # disproved it). The explicit `if` below tolerates skipped guards so: + # - pull_request: guards run; guard failure -> failure() -> legs skip + # (required checks show pending, merge blocked — #2637 semantics intact) + # - push/dispatch: PR-only guards skip harmlessly, legs RUN — master gets + # a real post-merge test signal (the missing master-push hole, #3197 era) + test: + needs: [version-guard, kernel-guard, pi-subagents-guard, lane-guard, docs-sync, docs-coverage, unused-exports, lock-sync, test-import-graph] + if: ${{ !failure() && !cancelled() }} # #3143: the suite outgrew one runner — ~656 top-level files (~190k LOC) now # serialize through c=4 on a single 4-core leg for ~17-20 min (windows slowest; # measured 1225s on the last full green run). Sharding spreads the SAME files @@ -45,8 +55,6 @@ jobs: # same tests/assertions/env, c=4 within each shard). Wall drops ~3x (~20 -> ~7min) # with zero coverage loss. To go faster, add entries to the list AND bump the "/3" # below together (they must stay equal). - test: - needs: [version-guard, kernel-guard, pi-subagents-guard, lane-guard, docs-sync, docs-coverage, unused-exports, lock-sync, test-import-graph] strategy: fail-fast: false matrix: