From 873369a48a993a47141804d1ed787a74debc2f8d Mon Sep 17 00:00:00 2001 From: Victor Nunes Date: Mon, 1 Oct 2018 23:26:14 -0300 Subject: [PATCH] Use strings.Builder instead of bytes.Buffer Since version 1.10, the language supports strings.Builder. This builder is more optimized than bytes.Buffer (https://medium.com/@thuc/8-notes-about-strings-builder-in-golang-65260daae6e9). In addition, the packge bytes was only used in that part of the code, reducing an import after this commit. --- core.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core.go b/core.go index 8bb345f..fce7c23 100644 --- a/core.go +++ b/core.go @@ -7,7 +7,6 @@ package strset */ import ( - "bytes" "sort" "strings" ) @@ -72,11 +71,11 @@ func (s Set) ToSlice() []string { func (s Set) String() string { elems := s.ToSlice() sort.Strings(elems) - var buf bytes.Buffer - buf.WriteString("Set{") - buf.WriteString(strings.Join(elems, " ")) - buf.WriteByte('}') - return buf.String() + var builder strings.Builder + builder.WriteString("Set{") + builder.WriteString(strings.Join(elems, " ")) + builder.WriteByte('}') + return builder.String() } // allIn reports whether all elements of s exist in other.