Skip to content

Update PyClient to use a std::unique_ptr for Underlying C++ Client #21

Description

@MattToast

Currently in Client.pyx, the PyClient class has a single attr that is a pointer to an IClient. This pointer should be unique and is owned by the class (e.g. the memory is cleaned up on object destruction). Both of these invariants can be better expressed with a std::unique_ptr, we should change over to it. This has the bonus condition that we likely can remove the __dealloc__ block from the PyClient entirely.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions