Skip to content

increase street layer maximum extent #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophfink wants to merge 3 commits into
base: patched_v7.3
Choose a base branch
from
Open

increase street layer maximum extent #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88de710
increase street layer maximum extent
christophfink Dec 19, 2024
6117799
increase MAX_BOUNDING_BOX_AREA_SQ_KM to Earth's surface area
christophfink Jan 28, 2025
081d5ea
exceptions are not triggered without artificial extent restrictions
christophfink Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/conveyal/r5/common/GeometryUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ public class GeometryUtils {
/** Average of polar and equatorial radii, https://en.wikipedia.org/wiki/Earth */
public static final double RADIUS_OF_EARTH_M = 6_367_450;

/** Maximum area allowed for the bounding box of uploaded files -- large enough for California. */
private static final double MAX_BOUNDING_BOX_AREA_SQ_KM = 975_000;
/** Maximum area allowed for the bounding box of uploaded files -- large enough for Earth. */
private static final double MAX_BOUNDING_BOX_AREA_SQ_KM = 510_073_000;

/**
* Haversine formula for distance on the sphere. We used to have a fastDistance function that would estimate this
Expand Down
12 changes: 6 additions & 6 deletions src/test/java/com/conveyal/analysis/datasource/SpatialDataSourceIngesterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ void basicValid (FileStorageFormat format) {
}
}

/** Test on files containing huge shapes: the continents of Africa, South America, and Australia. */
@ParameterizedTest
@EnumSource(names = {"GEOPACKAGE", "GEOJSON", "SHP"})
void continentalScale (FileStorageFormat format) {
assertIngestException(format, "continents", IllegalArgumentException.class, "exceeds");
}
// /** Test on files containing huge shapes: the continents of Africa, South America, and Australia. */
// @ParameterizedTest
// @EnumSource(names = {"GEOPACKAGE", "GEOJSON", "SHP"})
// void continentalScale (FileStorageFormat format) {
// assertIngestException(format, "continents", IllegalArgumentException.class, "exceeds");
// }

/**
* Test on projected (non-WGS84) data containing shapes on both sides of the 180 degree antimeridian.
Expand Down