Ga.ReciprocalFrame is nonsensical

[eric-wieser]

This behavior doesn't make much sense to me:

>>> from galgebra.ga import Ga
>>> g, *_ = Ga.build('e*0|1|2')
>>> g.ReciprocalFrame(g.basis)
(1, -1, (e_1.e_2)/(e_2.e_2) + e_1^e_2/(e_2.e_2))
>>> g.ReciprocalFrame(g.basis, mode='no-norm-please')  # any string will do
((e_2.e_2)*1**2,
 -(e_2.e_2)*1**2,
 (e_1.e_2)*1**2 + 1**2*e_1^e_2,
 (e_2.e_2)*1**2)

Things which are weird here:

• I was expecting to get some vector elements in this output, not a mixture of scalars and bivectors.
• 1 is actually Symbol('1'), not the value 1, in the second output! (fixed in Cleanup ReciprocalFrame #219)

Labelling as docs too, since there is no docstring

[utensil]

The second output certainly should be corrected. What's you exact expected output in the first one?

[eric-wieser]

This issue was caused by using basis and not mv_basis

[utensil]

Is this fully addressed by #219 ? @eric-wieser

[eric-wieser]

Nope, added a checkbox for the bullet points above. g.ReciprocalFrame(g.basis) ought to error instead of producing garbage, which is caused by g.mv_basis[0] ^ g.basis[1] behaving poorly

[eric-wieser]

Removed the docs tag, since this now has a docstring and type annotations.