From 988a0b4e38d9cd1720d3822c51a02e7ca7528079 Mon Sep 17 00:00:00 2001 From: Pip Liggins Date: Wed, 2 Sep 2026 14:19:58 +0100 Subject: [PATCH 1/4] bug: remove job_name from benchmark_memory --- .github/workflows/benchmarks_pr.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/benchmarks_pr.yml b/.github/workflows/benchmarks_pr.yml index 21d0138f50..07dbd98102 100644 --- a/.github/workflows/benchmarks_pr.yml +++ b/.github/workflows/benchmarks_pr.yml @@ -120,5 +120,4 @@ jobs: with: sessions: benchmark-memory legs: '[{"os": "ubuntu-latest", "python": "3.13"}]' - job_name: Memory benchmarks texlive: false From 06bc2e190bd8a8038d7b5960c5e57454be9e0cf5 Mon Sep 17 00:00:00 2001 From: Pip Liggins Date: Wed, 2 Sep 2026 14:22:10 +0100 Subject: [PATCH 2/4] ci: update bencher key --- .github/workflows/benchmarks_main.yml | 6 +++--- .github/workflows/benchmarks_track.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/benchmarks_main.yml b/.github/workflows/benchmarks_main.yml index 0d50fda2b6..134c486af7 100644 --- a/.github/workflows/benchmarks_main.yml +++ b/.github/workflows/benchmarks_main.yml @@ -70,11 +70,11 @@ jobs: . # The registry pairs a project key with the project slug as the username - # (a user key would pair with the owner's email instead), so BENCHER must + # (a user key would pair with the owner's email instead), so BENCHER_PROJECT must # hold a `bencher_run_*` key. - name: Log in to the Bencher registry env: - BENCHER_API_KEY: ${{ secrets.BENCHER }} + BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} run: | printf '%s' "$BENCHER_API_KEY" \ | docker login "$BENCHER_REGISTRY" --username "$BENCHER_PROJECT" --password-stdin @@ -86,7 +86,7 @@ jobs: - name: Track main branch benchmarks with Bencher env: - BENCHER_API_KEY: ${{ secrets.BENCHER }} + BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | bencher run \ diff --git a/.github/workflows/benchmarks_track.yml b/.github/workflows/benchmarks_track.yml index 258d50d5f2..df4d7ab391 100644 --- a/.github/workflows/benchmarks_track.yml +++ b/.github/workflows/benchmarks_track.yml @@ -85,12 +85,12 @@ jobs: docker tag pybamm-benchmarks:pr "$BENCHER_REGISTRY/$BENCHER_PROJECT:pr-$PR_HEAD_SHA" # The registry pairs a project key with the project slug as the username - # (a user key would pair with the owner's email instead), so BENCHER must + # (a user key would pair with the owner's email instead), so BENCHER_PROJECT must # hold a `bencher_run_*` key. - name: Log in to the Bencher registry if: steps.artifact.outputs.found == 'true' env: - BENCHER_API_KEY: ${{ secrets.BENCHER }} + BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} run: | printf '%s' "$BENCHER_API_KEY" \ | docker login "$BENCHER_REGISTRY" --username "$BENCHER_PROJECT" --password-stdin @@ -107,7 +107,7 @@ jobs: - name: Track PR benchmarks with Bencher if: steps.artifact.outputs.found == 'true' env: - BENCHER_API_KEY: ${{ secrets.BENCHER }} + BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | bencher run \ From db80b1e965dc11a9e95cd869937dc014bca144c7 Mon Sep 17 00:00:00 2001 From: Pip Liggins Date: Wed, 2 Sep 2026 14:47:37 +0100 Subject: [PATCH 3/4] Revert "ci: update bencher key" This reverts commit 06bc2e190bd8a8038d7b5960c5e57454be9e0cf5. --- .github/workflows/benchmarks_main.yml | 6 +++--- .github/workflows/benchmarks_track.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/benchmarks_main.yml b/.github/workflows/benchmarks_main.yml index 134c486af7..0d50fda2b6 100644 --- a/.github/workflows/benchmarks_main.yml +++ b/.github/workflows/benchmarks_main.yml @@ -70,11 +70,11 @@ jobs: . # The registry pairs a project key with the project slug as the username - # (a user key would pair with the owner's email instead), so BENCHER_PROJECT must + # (a user key would pair with the owner's email instead), so BENCHER must # hold a `bencher_run_*` key. - name: Log in to the Bencher registry env: - BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} + BENCHER_API_KEY: ${{ secrets.BENCHER }} run: | printf '%s' "$BENCHER_API_KEY" \ | docker login "$BENCHER_REGISTRY" --username "$BENCHER_PROJECT" --password-stdin @@ -86,7 +86,7 @@ jobs: - name: Track main branch benchmarks with Bencher env: - BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} + BENCHER_API_KEY: ${{ secrets.BENCHER }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | bencher run \ diff --git a/.github/workflows/benchmarks_track.yml b/.github/workflows/benchmarks_track.yml index df4d7ab391..258d50d5f2 100644 --- a/.github/workflows/benchmarks_track.yml +++ b/.github/workflows/benchmarks_track.yml @@ -85,12 +85,12 @@ jobs: docker tag pybamm-benchmarks:pr "$BENCHER_REGISTRY/$BENCHER_PROJECT:pr-$PR_HEAD_SHA" # The registry pairs a project key with the project slug as the username - # (a user key would pair with the owner's email instead), so BENCHER_PROJECT must + # (a user key would pair with the owner's email instead), so BENCHER must # hold a `bencher_run_*` key. - name: Log in to the Bencher registry if: steps.artifact.outputs.found == 'true' env: - BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} + BENCHER_API_KEY: ${{ secrets.BENCHER }} run: | printf '%s' "$BENCHER_API_KEY" \ | docker login "$BENCHER_REGISTRY" --username "$BENCHER_PROJECT" --password-stdin @@ -107,7 +107,7 @@ jobs: - name: Track PR benchmarks with Bencher if: steps.artifact.outputs.found == 'true' env: - BENCHER_API_KEY: ${{ secrets.BENCHER_PROJECT }} + BENCHER_API_KEY: ${{ secrets.BENCHER }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | bencher run \ From 2985149cce449537b811947744e1f88904087b63 Mon Sep 17 00:00:00 2001 From: Pip Liggins Date: Wed, 2 Sep 2026 15:05:59 +0100 Subject: [PATCH 4/4] empty commit to force benchmark re-run