Adding support for other types of .bsp

[snake-biscuits]

I’d like to add support for Respawn’s .bsp formats, sharing what I’ve mapped out of the format in https://github.com/snake-biscuits/bsp_tool
However respawn bsps have a different header and have many of their lumps stored in external files.

considering these differences, would it be best to create a new class for handling respawn bsps, like in my repo?

[maxdup]

Curious, have you done research into lump patch files? https://developer.valvesoftware.com/wiki/Patching_levels_with_lump_files
Can you determine if they function the same and whether or not they might be the same technology?
From a surface level I notice they have different file extensions but it feels like they'd be very similar.

In any case, the parsing of lumps is already more or less individual. The current implementation could be somewhat conducive to lumps as individual files. It will be tricky to keep track of all the source files tho.

As for the bsp header, it is the only place where titanfall is already supported https://github.com/pySourceSDK/ValveBSP/blob/master/valvebsp/structs/bsp_header.py#L42

[snake-biscuits]

Iirc lump patch files for source are the contents of a lump with a lump header at the start

Titanfall .bsp_lump files have no header, just the contents of the lump

also the byte-magic for respawn .bsps is b’rBSP’, not b’VBSP’

[snake-biscuits]

Looking at VDC it seems like .lump are a little more complicated than I remembered: https://developer.valvesoftware.com/wiki/Lump_file_format

[maxdup]

I'm thinking about supporting both in one go, it would be a substantial refactor tho

[snake-biscuits]

Well, for me to add mappings for what respawn lumps I know there'd probably need to be a refactor anyway
I figure sharing files for totally different lumps in valvebsp/structs/ would be pretty confusing
Personally I'd give respawn bsps their own folder like in my repo, since they're so different from source .bsps

I'll leave that decision to you though, seeing as it's your repo