From 191aade5c57a7039eecb9ac6cb38f6fd5fd9fd7d Mon Sep 17 00:00:00 2001 From: kylerankin Date: Sat, 19 Sep 2026 14:56:36 +0000 Subject: [PATCH] fix: disable nvidia-container repo on non-NVIDIA flavors packages/nvidia-container.repo shipped enabled=1 and was copied into every image via the Containerfile's yum.repos.d COPY, so a plain utah or utah-gaming install exposed NVIDIA's third-party runtime repository even though scripts/install-nvidia.sh -- the only thing that installs from it -- runs solely on the nvidia flavors. That contradicts the policy that Utah's runtime repositories are Hummingbird plus the pinned utah-packages factory. Ship the repo enabled=0 everywhere (the COPY stays; it is harmless disabled) and turn it on for the single install transaction on the NVIDIA flavors, --enablerepo=nvidia-container-toolkit, the same narrow window #133 gives utah-packages.repo. Non-NVIDIA images now list only Hummingbird in `dnf repolist`, while the NVIDIA flavors still install nvidia-container-toolkit with repo_gpgcheck=1 and the pinned fingerprint intact. Assisted-by: lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K Co-authored-by: Claude https://claude.ai/ghost --- packages/nvidia-container.repo | 2 +- scripts/install-nvidia.sh | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/nvidia-container.repo b/packages/nvidia-container.repo index 5bfa14f1..94e67dc0 100644 --- a/packages/nvidia-container.repo +++ b/packages/nvidia-container.repo @@ -21,7 +21,7 @@ [nvidia-container-toolkit] name=nvidia-container-toolkit baseurl=https://nvidia.github.io/libnvidia-container/stable/rpm/$basearch -enabled=1 +enabled=0 repo_gpgcheck=1 gpgcheck=0 gpgkey=https://nvidia.github.io/libnvidia-container/gpgkey diff --git a/scripts/install-nvidia.sh b/scripts/install-nvidia.sh index 8105eb39..0d5c3245 100755 --- a/scripts/install-nvidia.sh +++ b/scripts/install-nvidia.sh @@ -258,7 +258,12 @@ sh "$run_path" --silent --no-kernel-module --no-nouveau-check \ # bundle was one source, not the only one: NVIDIA publishes the toolkit itself, # from a path with no distribution version in it, and its dependencies are base # OS libraries Hummingbird already has. See packages/nvidia-container.repo. -"$DNF" -y install nvidia-container-toolkit +# +# The repository ships enabled=0 so only these flavors expose it, and it is +# switched on for this transaction alone (--enablerepo), the same narrow window +# #133 gives utah-packages.repo. A non-NVIDIA image therefore lists only +# Hummingbird in `dnf repolist`, which is the acceptance for #169. +"$DNF" -y install --enablerepo=nvidia-container-toolkit nvidia-container-toolkit # /usr/lib/utah is created by install-ogc-kernel.sh, but that only runs on the # gaming flavors, so on plain nvidia nothing has made it yet.