From a13e40a9237496b4d08fbb06ff6fa8058524e7da Mon Sep 17 00:00:00 2001 From: hive-agent Date: Sat, 19 Sep 2026 14:16:52 +0000 Subject: [PATCH 1/2] fix(ci): pin just tool version in CI workflows taiki-e/install-action resolves just@latest at run time when no version is supplied, so the build tool that drives every job (just validate, just test-unit, DDI/kernel export recipes) was unpinned while every GitHub Action in the repo is SHA-pinned. Pin just to 1.58.0, the version CI already installs, so this changes no runtime behavior. Signed-off-by: hive-agent --- .github/workflows/build.yml | 4 ++-- .github/workflows/kernel.yml | 2 +- .github/workflows/unit-tests.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bf99f8ea..ed4cba99 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -39,7 +39,7 @@ jobs: - name: Set up just uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2 with: - tool: just + tool: just@1.58.0 - name: Track and Resolve BuildStream Refs env: @@ -77,7 +77,7 @@ jobs: - name: Set up just uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2 with: - tool: just + tool: just@1.58.0 - name: Validate Element Graph run: just validate diff --git a/.github/workflows/kernel.yml b/.github/workflows/kernel.yml index 6d420e86..3d1cf6e4 100644 --- a/.github/workflows/kernel.yml +++ b/.github/workflows/kernel.yml @@ -39,7 +39,7 @@ jobs: - name: Set up just uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2 with: - tool: just + tool: just@1.58.0 - name: Validate Element Graph run: just validate diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index fc4485d7..32bbcba1 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -41,7 +41,7 @@ jobs: - name: Set up just uses: taiki-e/install-action@7b8d4719ee4aaa279bdf55df38dacb9ebfe12a6c # v2 with: - tool: just + tool: just@1.58.0 - name: Run unit tests run: just test-unit From 668ffd1a7b68f7aaedd8e87b1a7fe7f57c280ab6 Mon Sep 17 00:00:00 2001 From: ci-maintainer Date: Sat, 19 Sep 2026 20:18:10 -0400 Subject: [PATCH 2/2] docs(ci-tooling): pin the tool version in the canonical just snippet The skill doc's install snippet still showed an unpinned 'tool: just', which is the form issue #188 removed from the workflows. A workflow copied from the doc would have reintroduced it, undoing this PR on the next new job. Update the snippet to 'tool: just@1.58.0', matching all four call sites, and explain that without a version install-action resolves just@latest at run time. Note that the version is repeated per call site so a bump has to change all of them in one commit. Add the half-done pin to Red Flags, add a checklist item for it under Verification, and record the 'tool: just always installs a working version' rationalization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- docs/skills/ci-tooling.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/docs/skills/ci-tooling.md b/docs/skills/ci-tooling.md index e236f99f..0ef33331 100644 --- a/docs/skills/ci-tooling.md +++ b/docs/skills/ci-tooling.md @@ -42,12 +42,21 @@ before adding an action. ### Installing `just` — taiki-e/install-action, not snap/cargo/apt +Pin the tool version too, not only the action SHA. Without `@`, +`install-action` resolves `just@latest` at run time, so the CI contract +(`just validate`, `just test-unit`, the DDI/kernel export recipes) runs against +a binary chosen by an upstream release rather than by a commit in this repo. + ```yaml - uses: taiki-e/install-action@b6b84cf49ebfe0176417bdce007c624f0db37f20 # v2 with: - tool: just + tool: just@1.58.0 ``` +The version is repeated at each call site — currently `build.yml` (two jobs), +`kernel.yml` and `unit-tests.yml`. Bumping `just` means changing all of them in +one commit, so CI never runs two versions at once. + ### Workflow permissions `.github/workflows/build.yml` defaults to a read-only token: @@ -130,10 +139,13 @@ uploaded to a GitHub Release tagged `installer-v`. |---|---| | "It's just a minor version tag, supply-chain risk is low." | One compromised tag push owns every repo using it. Pin to SHA. | | "I'll check what SHA other repos use later." | Check now — it's one `gh api` call and takes a few seconds. | +| "`tool: just` always installs a working version." | It installs whatever is latest that day. A `just` release can change recipe parsing or `--fmt` output and break CI with no commit in this repo. | ## Red Flags - Any `uses:` line with a mutable ref (`@v2`, `@main`, `@latest`). +- An `install-action` step whose `tool:` has no `@` — the pin is half + done, since the action is fixed but the binary it installs is not. - `sudo podman` in one step and plain `podman` in another step doing the same operation. - A new action not present in any sibling repo — check upstream first. @@ -141,6 +153,7 @@ uploaded to a GitHub Release tagged `installer-v`. ## Verification - [ ] Every `uses:` line has a full 40-character SHA and a `# vX` comment. +- [ ] Every `install-action` `tool:` names an explicit version (`just@1.58.0`). - [ ] `just validate` passes after workflow changes. - [ ] No new mutable action refs introduced. - [ ] The release signing step uploads detached `.gpg` signatures for every