From 589d5d7094799eae1a5cd47b261aaaeb216a10b3 Mon Sep 17 00:00:00 2001 From: mrbobbytables Date: Thu, 17 Sep 2026 04:28:25 +0000 Subject: [PATCH 1/2] fix(boot): remove udevd sysext ordering drop-in to prevent var mount deadlock In elements/flatcar/flatcar-zfs.bst, the extracted Flatcar ZFS sysext archive contains usr/lib/systemd/system/systemd-udevd.service.d/10-zfs.conf which configures After=systemd-sysext.service. Because Bluefin Server extracts ZFS directly into /usr at build time, this ordering override is unnecessary. In addition, systemd-sysext.service runs After=local-fs.target, which waits for var.mount. Because var.mount requires the underlying block device unit from systemd-udevd to transition to active, this caused a circular dependency deadlock during target boot where udevd could never start, resulting in systemd timing out waiting for /dev/disk/by-partlabel/var. Remove systemd-udevd.service.d during flatcar-zfs installation, and add contract assertions in test_installer_contract.py. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables --- elements/flatcar/flatcar-zfs.bst | 8 +++++++ tests/unit/test_installer_contract.py | 31 +++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/elements/flatcar/flatcar-zfs.bst b/elements/flatcar/flatcar-zfs.bst index 82832969..df335cef 100644 --- a/elements/flatcar/flatcar-zfs.bst +++ b/elements/flatcar/flatcar-zfs.bst @@ -31,3 +31,11 @@ config: # Also preserve the raw sysext image under /usr/lib/sysexts for runtime sysext usage mkdir -p "%{install-root}/usr/lib/sysexts" install -D -m 0644 flatcar-zfs.raw "%{install-root}/usr/lib/sysexts/zfs.raw" + + # Drop Flatcar's udevd sysext ordering override. In Flatcar, ZFS is loaded as + # a runtime sysext, so udevd was ordered After=systemd-sysext.service. + # In Bluefin Server, ZFS is extracted directly into the OS rootfs at build time. + # Leaving this drop-in causes systemd-udevd to wait for systemd-sysext.service, + # which waits for local-fs.target, which waits for var.mount, which waits for + # the udev device unit — creating a boot deadlock. + rm -rf "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d" diff --git a/tests/unit/test_installer_contract.py b/tests/unit/test_installer_contract.py index d423c685..b6f406c6 100644 --- a/tests/unit/test_installer_contract.py +++ b/tests/unit/test_installer_contract.py @@ -14,6 +14,7 @@ ) JUSTFILE = REPO_ROOT / "Justfile" DDI_ELEMENT = REPO_ROOT / "elements" / "oci" / "bluefin-server-ddi.bst" +FLATCAR_ZFS_ELEMENT = REPO_ROOT / "elements" / "flatcar" / "flatcar-zfs.bst" def _published_uki_cmdline(installer_element: str) -> str: @@ -135,3 +136,33 @@ def test_installer_and_ddi_strip_vmlinux_and_static_archives() -> None: assert "find /layer -type f -name '*.a' -delete" in installer_element assert 'rm -f "/layer/usr/lib/modules/${KVER}/vmlinux"' in ddi_element assert "find /layer -type f -name '*.a' -delete" in ddi_element + + +def test_flatcar_zfs_removes_udevd_sysext_ordering_dropin() -> None: + flatcar_zfs = FLATCAR_ZFS_ELEMENT.read_text(encoding="utf-8") + + assert ( + 'rm -rf "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d"' + in flatcar_zfs + ) + + +def test_var_partition_contracts_use_consistent_partlabel() -> None: + import base64 + + repart_var = ( + REPO_ROOT / "files" / "installer" / "repart.d" / "30-var.conf" + ).read_text(encoding="utf-8") + ddi_element = DDI_ELEMENT.read_text(encoding="utf-8") + var_mount = ( + REPO_ROOT / "files" / "os" / "systemd" / "system" / "var.mount" + ).read_text(encoding="utf-8") + justfile = JUSTFILE.read_text(encoding="utf-8") + + assert "Label=var" in repart_var + assert "/dev/disk/by-partlabel/var /var xfs defaults 0 0" in ddi_element + assert "What=/dev/disk/by-partlabel/var" in var_mount + expected_b64 = base64.b64encode( + b"/dev/disk/by-partlabel/var /var xfs defaults 0 0\n" + ).decode("ascii") + assert expected_b64 in justfile From 84156e34128fafed64ea07495af9d870be5e1ed4 Mon Sep 17 00:00:00 2001 From: mrbobbytables Date: Sat, 19 Sep 2026 22:59:24 +0000 Subject: [PATCH 2/2] fix(flatcar-zfs): target 10-zfs.conf specifically when removing udevd sysext ordering drop-in Address review feedback from @kubestellar-hive: surgically target 10-zfs.conf rather than removing the entire systemd-udevd.service.d directory, preserving any future drop-ins that Flatcar sysexts might supply, and update test_installer_contract assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables --- elements/flatcar/flatcar-zfs.bst | 3 ++- tests/unit/test_installer_contract.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/elements/flatcar/flatcar-zfs.bst b/elements/flatcar/flatcar-zfs.bst index df335cef..c38ffb6f 100644 --- a/elements/flatcar/flatcar-zfs.bst +++ b/elements/flatcar/flatcar-zfs.bst @@ -38,4 +38,5 @@ config: # Leaving this drop-in causes systemd-udevd to wait for systemd-sysext.service, # which waits for local-fs.target, which waits for var.mount, which waits for # the udev device unit — creating a boot deadlock. - rm -rf "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d" + rm -f "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d/10-zfs.conf" + rmdir "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d" 2>/dev/null || true diff --git a/tests/unit/test_installer_contract.py b/tests/unit/test_installer_contract.py index b6f406c6..6a2c4ff3 100644 --- a/tests/unit/test_installer_contract.py +++ b/tests/unit/test_installer_contract.py @@ -142,7 +142,7 @@ def test_flatcar_zfs_removes_udevd_sysext_ordering_dropin() -> None: flatcar_zfs = FLATCAR_ZFS_ELEMENT.read_text(encoding="utf-8") assert ( - 'rm -rf "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d"' + 'rm -f "%{install-root}/usr/lib/systemd/system/systemd-udevd.service.d/10-zfs.conf"' in flatcar_zfs )