From 231746589f98ecf769b9ebf8bf64663334f7bb31 Mon Sep 17 00:00:00 2001 From: castrojo Date: Fri, 13 Nov 2026 19:27:08 -0500 Subject: [PATCH 1/2] fix(ci): grant ISO smoke runner scoped KVM access The existing smoke job fails to initialize KVM because /dev/kvm is not writable by the hosted runner user. Grant that user a device ACL rather than changing the smoke test, making the device world writable, or running QEMU as root. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/iso-smoke-test.yml | 7 ++++++- docs/skills/workflow-map.md | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/iso-smoke-test.yml b/.github/workflows/iso-smoke-test.yml index 1e42186..5a94647 100644 --- a/.github/workflows/iso-smoke-test.yml +++ b/.github/workflows/iso-smoke-test.yml @@ -181,7 +181,12 @@ jobs: - name: Install QEMU and ISO inspection tools run: | sudo apt-get update - sudo apt-get install --yes qemu-system-x86 xorriso + sudo apt-get install --yes acl qemu-system-x86 xorriso + + - name: Enable KVM for the runner user + run: | + sudo setfacl -m "u:$(id -un):rw" /dev/kvm + getfacl --absolute-names /dev/kvm - name: Run boot smoke test id: smoke diff --git a/docs/skills/workflow-map.md b/docs/skills/workflow-map.md index f122020..7f2a50d 100644 --- a/docs/skills/workflow-map.md +++ b/docs/skills/workflow-map.md @@ -57,6 +57,7 @@ Do not use this skill for implementation changes that belong in the workflow fil ## Operational notes - The reusable build job runs `ublue-os/remove-unwanted-software` with `extra-squeeze` before dependency installation and checkout on both amd64 and arm64. Keep it at the start of the job because Titanoboa expands the source image's OSTree layers onto the runner. This provides disk headroom; it does not establish that a failed build ran out of space. +- `iso-smoke-test.yml` grants only the current runner user read/write access to `/dev/kvm` with a named-user ACL before QEMU starts. Keep the device's owner/group and other-user permissions intact; the unchanged smoke harness retains its `kvm:tcg` accelerator selection. - The cleanup action is pinned to the untagged `695eb75bc387dbcd9685a8e72d23439d8686cba6` commit from 2025-10-10. Do not label it `v10`: that was an upstream branch name, not a release tag. The released `v9` does not expose `extra-squeeze`; verify both tag provenance and inputs before changing the pin. - `just check` and pre-commit validate formatting and syntax, not ISO build or installation success. Inspect the individual CI jobs: arm64 build failures are tolerated while upstream manifests are incomplete, and Stable E2E jobs are skipped if their prerequisite build fails. - LTS non-HWE production promotion is disabled while the LTS build remains broken. From 74f076f12bc38f0b78a9fa3699dfd6d1f061c303 Mon Sep 17 00:00:00 2001 From: castrojo Date: Fri, 13 Nov 2026 19:36:44 -0500 Subject: [PATCH 2/2] fix(ci): grant KVM access before each ISO smoke invocation The full unchanged smoke run showed the first QEMU could use KVM while a later invocation again received Permission denied. Scope the existing ACL setup directly before each invocation, preserving every ISO and existing outcome rule. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/iso-smoke-test.yml | 7 ++----- docs/skills/workflow-map.md | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/iso-smoke-test.yml b/.github/workflows/iso-smoke-test.yml index 5a94647..82c12a2 100644 --- a/.github/workflows/iso-smoke-test.yml +++ b/.github/workflows/iso-smoke-test.yml @@ -183,11 +183,6 @@ jobs: sudo apt-get update sudo apt-get install --yes acl qemu-system-x86 xorriso - - name: Enable KVM for the runner user - run: | - sudo setfacl -m "u:$(id -un):rw" /dev/kvm - getfacl --absolute-names /dev/kvm - - name: Run boot smoke test id: smoke continue-on-error: true @@ -199,6 +194,8 @@ jobs: [[ -n "$iso_path" ]] || continue output_dir="smoke-output/$(basename "${iso_path%.*}")" mkdir -p "$output_dir" + sudo setfacl -m "u:$(id -un):rw" /dev/kvm + getfacl --absolute-names /dev/kvm if ! tests/iso/smoke.sh "$iso_path" "$output_dir"; then status=1 fi diff --git a/docs/skills/workflow-map.md b/docs/skills/workflow-map.md index 7f2a50d..b8292d0 100644 --- a/docs/skills/workflow-map.md +++ b/docs/skills/workflow-map.md @@ -57,7 +57,7 @@ Do not use this skill for implementation changes that belong in the workflow fil ## Operational notes - The reusable build job runs `ublue-os/remove-unwanted-software` with `extra-squeeze` before dependency installation and checkout on both amd64 and arm64. Keep it at the start of the job because Titanoboa expands the source image's OSTree layers onto the runner. This provides disk headroom; it does not establish that a failed build ran out of space. -- `iso-smoke-test.yml` grants only the current runner user read/write access to `/dev/kvm` with a named-user ACL before QEMU starts. Keep the device's owner/group and other-user permissions intact; the unchanged smoke harness retains its `kvm:tcg` accelerator selection. +- `iso-smoke-test.yml` grants only the current runner user read/write access to `/dev/kvm` with a named-user ACL before each smoke invocation. Keep the device's owner/group and other-user permissions intact; the unchanged smoke harness retains its `kvm:tcg` accelerator selection. - The cleanup action is pinned to the untagged `695eb75bc387dbcd9685a8e72d23439d8686cba6` commit from 2025-10-10. Do not label it `v10`: that was an upstream branch name, not a release tag. The released `v9` does not expose `extra-squeeze`; verify both tag provenance and inputs before changing the pin. - `just check` and pre-commit validate formatting and syntax, not ISO build or installation success. Inspect the individual CI jobs: arm64 build failures are tolerated while upstream manifests are incomplete, and Stable E2E jobs are skipped if their prerequisite build fails. - LTS non-HWE production promotion is disabled while the LTS build remains broken.