Skip to content

Power-of-Ten / code-quality backlog (function length, unwraps, clippy) #797

Description

@kwsantiago

Consolidated Power-of-Ten / code-quality backlog. Style/maintainability items, not security bugs.

Caveat: some are NOT safe to fix mechanically — splitting large exhaustive match dispatchers into sub-functions forces catch-all arms and discards compile-time match-exhaustiveness (trades correctness for a line count). Recommended scope: exempt exhaustive enum-dispatchers from the strict line limit; do genuine linear-function extractions and unwrap() reduction (security-critical crates first) with review; treat pedantic-clippy as opt-in.

Covers ~35 tracked items across Rule 4 (function length: App::update, frost_event_listener, handle_identity_message, handle_connection, handle_sign_psbt, handle_event, and ~57 functions >100 lines), Rule 7 (unwrap density), Rule 10 (pedantic-clippy warnings, allow() suppressions), Rule 2 (unbounded loops), Rule 5 (assertion density), Rule 6/9 (statics, unsafe/dyn). Pick a concrete function/rule and open a focused PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    p2PriorityrefactorCode restructuring without behavior changerustPull requests that update rust code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions