From f4e7fe82342dc32cd46159fa91030e0c003ff384 Mon Sep 17 00:00:00 2001 From: Pontus Alexander Date: Wed, 17 Sep 2025 22:44:51 +0200 Subject: [PATCH 1/3] Check for null in isIterator and add test Fixes TypeError: Cannot use 'in' operator to search for 'Symbol(Symbol.iterator)' in null --- src/__tests__/guards.test.ts | 37 ++++++++++++++++++++++++++++++++++++ src/guards.ts | 2 +- 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 src/__tests__/guards.test.ts diff --git a/src/__tests__/guards.test.ts b/src/__tests__/guards.test.ts new file mode 100644 index 0000000..e2aa479 --- /dev/null +++ b/src/__tests__/guards.test.ts @@ -0,0 +1,37 @@ +import { isIterable } from "../guards"; + +describe("Guards", () => { + describe("#record", () => { + it("returns true on array", () => { + expect(isIterable([])).toBe(true); + }); + + it("returns true on set", () => { + expect(isIterable(new Set())).toBe(true); + }); + + it("returns false on null", () => { + expect(isIterable(null)).toBe(false); + }); + + it("returns false on undefined", () => { + expect(isIterable(undefined)).toBe(false); + }); + + it("returns false on object", () => { + expect(isIterable({})).toBe(false); + }); + + it("returns false on string", () => { + expect(isIterable("")).toBe(false); + }); + + it("returns false on number", () => { + expect(isIterable(124)).toBe(false); + }); + + it("returns false on boolean", () => { + expect(isIterable(true)).toBe(false); + }); + }); +}); diff --git a/src/guards.ts b/src/guards.ts index dfb8a20..435c885 100644 --- a/src/guards.ts +++ b/src/guards.ts @@ -1,3 +1,3 @@ export function isIterable(value: any): value is Iterable { - return typeof value === "object" && Symbol.iterator in value; + return value != null && typeof value === "object" && Symbol.iterator in value; } From fefa6d4c20c64bf7e91006d5cd08b83f8726a1e5 Mon Sep 17 00:00:00 2001 From: Pontus Alexander Date: Wed, 17 Sep 2025 22:45:42 +0200 Subject: [PATCH 2/3] 0.1.4-0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a7a8e51..b2be235 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@pomle/shapes", - "version": "0.1.3", + "version": "0.1.4-0", "description": "TypeScript library for coalescing unknown data into well defined object shapes.", "author": "Pontus Alexander ", "license": "MIT", From 9f02adab3b3980e0b5116de13bb03092cacb0d6f Mon Sep 17 00:00:00 2001 From: Pontus Alexander Date: Wed, 17 Sep 2025 22:51:06 +0200 Subject: [PATCH 3/3] 0.1.4 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b2be235..2520a1e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@pomle/shapes", - "version": "0.1.4-0", + "version": "0.1.4", "description": "TypeScript library for coalescing unknown data into well defined object shapes.", "author": "Pontus Alexander ", "license": "MIT",