Support SPFx 1.23.2

[milanholemans]

Support SPFx version 1.23.2 for the following commands:

• spfx project upgrade
• spfx project doctor
• spfx doctor

[brianpmccullough]

@milanholemans I can tackle this between today and tomorrow if it's not already being worked on?

[milanholemans]

Definitely! Thanks for the help.

[brianpmccullough]

@milanholemans qq. when I am working through PR, I am working in my fork. You want PR on my "main" against cli "main"?

[brianpmccullough]

@milanholemans perfect timing, token limits reset today ;)

[milanholemans]

@milanholemans qq. when I am working through PR, I am working in my fork. You want PR on my "main" against cli "main"?

You should target the CLI main branch indeed. But we recommend you create a new branch on your fork and create a PR from this. This way your forked main remains untouched and can still pull new commits from the original repo.

More info can be found at: https://pnp.github.io/cli-microsoft365/contribute/creating-the-pr

[brianpmccullough]

@milanholemans one last question, for the "optional dependencies" test project (in this case: spfx-1230-webpart-optionaldeps), am I correct in assessing that it appears to be a React web part, but with additional @microsoft/sp-* dependencies added. Presumably this is to test that each rule associated with each dependency correctly executes?

[milanholemans]

Uhm yeah, if I recall correctly, it's a non-react project with additional dependencies.

[brianpmccullough]

@milanholemans #7434 is in DRAFT state. Is there guidance for building locally (mac) and testing the commands, for example against 1.23.0 scaffolded test projects?

Note: While I used AI tooling, I was very active in reviewing the plans and execution and comparing against previous PRs. I had to steer it to include spfx-1230-formcustomizer-react and spfx-1232-webpart-react (both initially excluded).