Skip to content

java_toolchain should support specifying a toolchain URL via OS architecture #55

Description

@weaversam8

I'm new to Please, but looking at the source code, it appears that java_toolchain only checks CONFIG.OS and does not check CONFIG.ARCH:

if not jdk:
jdk_url = jdk_url if isinstance(jdk_url, str) else jdk_url.get(CONFIG.OS)
if not jdk_url:
fail(f"No jdk_url defined for platform {CONFIG.OS}")
jdk = remote_file(
name=f"_{name}#download",
url = jdk_url,
visibility = visibility,
hashes = hashes,
)

As of right now, that forces developers to either work around this in user code or fork this plugin.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions