Skip to content

go_benchmark rule produces two redundant pkginfo targets #359

Description

@hartblanc

Both the go_test and go_benchmark rule produce two hidden go_library targets.
_{name}#lib and _{name}#main_lib.

Both rules also explicitly call _go_pkg_info to produce a pkg_info target for the rule.

The go_test rule includes the _generate_pkg_info = False argument on the hidden go_library targets to prevent them from producing any associated pkg_info targets. This ensures that it only produces on pkginfo target.

The go_benchmark rule does not do this and so it produces three independent pkginfo targets for the same sources.
All three packages are included in the response when calling the gopackagesdriver.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions