Base64 images matched as external URLs

[andresscode]

Problem

The following line is making the No Network Calls check fail:

this.load.image('myBase64Image', 'data:image/png;base64,iVBORw0KGgoAAAA...')

The regex isn't excluding the data:image/ URLs.

platanus-hack-25-arcade/check-restrictions.lib.ts

Line 65 in 2ef67b2

const externalUrlPattern = /(https?:\/\/|\/\/[a-zA-Z0-9])/g;

Solution

A simple solution is to exclude from the gameCode the data images:

const lines = gameCode.replace(/data:[^,]+,[^\s'"`)]+/g, '').split('\n');

cc @rafafdz

[warleon]

The regex isn't excluding the data:image/ URLs.

The issue isn’t caused by the "data:image/" part. The real problem lies in the second part of the regex — the one that matches any double slash followed by a letter (e.g., //a). Since the / character frequently appears in Base64 strings, it’s only a matter of time before that pattern occurs by coincidence. I ran into the same issue when handling JavaScript comments as well.

Simply removing the second part of the or condition in the regex should fix the issue.

[andresscode]

Hey guys. Any updates on this issue? Updated my fork today with a commit from yesterday but didn't include a fix for this. Cheers.

[warleon]

@rafafdz esto esta causando un falso positivo en mi juego 🤕