Replies: 2 comments
|
PR #4148 has been refreshed without opening a new PR: branch |
|
Follow-up now that this shipped: Cmd+W still closes the whole window on macOS when no right-panel tab or terminal is focused, which is the state you are in during a normal chat. The handler in Threads already behave like tabs: they sit in a list, Cmd+1..9 jumps between them, Cmd+Shift+[ and ] cycle them. Every tabbed Mac app (Safari, Chrome, VS Code, iTerm, Finder) closes the current tab on Cmd+W and only closes the window when the last tab goes. Proposal:
Related: #10161 covers the Windows side where the same fall-through quits the app. |
Uh oh!
There was an error while loading. Please reload this page.
Before submitting
Area
apps/web
Problem or use case
When keyboard focus is inside a Files, Diff, Browser, Plan, or Terminal surface in the right panel, pressing
Cmd+Wcloses the T3 Code app window instead of closing the active panel tab.T3 Code already binds
mod+wto close a focused terminal, but there is no corresponding command or focus context for non-terminal right-panel surfaces. This is surprising for a tabbed interface and makes a common tab-closing shortcut destructive.Proposed solution
Add a configurable
rightPanel.closeActiveSurfacecommand with a defaultmod+wbinding gated by right-panel focus.Why this matters
Cmd+Wis a standard close-tab shortcut. Applying it to the focused panel tab prevents accidental app-window closure and makes right-panel tabs behave consistently with terminal tabs and other desktop tabbed interfaces.Smallest useful scope
Introduce one keybinding command and a right-panel focus context, then route it to the existing active-surface close callback. No new panel state, confirmation dialog, or queue of close actions.
Alternatives considered
keydownlistener in the tab component. This bypasses T3 Code's configurable keybinding system and creates conflicts with the existing terminal binding.Cmd+Wwhenever the panel is visible. That would close a panel tab even when the user is actively typing in the chat composer.Risks or tradeoffs
terminal.close; right-panel focus must take precedence for a terminal hosted as a panel surface while drawer terminals keep their current behavior.Examples or references
Related discoverability issue: #4146.
Contribution
All reactions