From 805989b4b405dced588845cca73022cee0dd46b6 Mon Sep 17 00:00:00 2001
From: Lucas Vogel <lucas.vogel@endpointsystems.com>
Date: Fri, 11 Sep 2026 11:57:27 -0400
Subject: [PATCH] build: dev mode for XSpec.Cli against the engine checkouts
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Adds the Directory.Build.targets that phoenixmldb-xquery and
phoenixmldb-xslt carry (identical copy): with dev mode on, the
PhoenixmlDb.{Core,XQuery,Xslt} PackageReferences become ProjectReferences to
the sibling engine checkouts, so this package can be built and tested
against engine main before a release — which lockstep releases need, since
this package now ships in the same train as the engines.

On with `touch <workspace>/.phoenixml-dev` (outside every repo),
PHOENIXML_DEV=1, or -p:PhoenixmlDev=true. Nothing committed changes when
toggled. Packing in dev mode, dev mode under CI, and a missing sibling are
all errors. Package mode — the default, and all CI sees — is unchanged.

Verified: tests pass in both modes; in dev mode the test output carries
engine main's code (checked by symbol); pack refuses in dev mode. Also
verified this package builds and passes its tests against engine 1.7.0.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XFzQJEPHoRxrjH6bni8tVn
---
 dotnet/Directory.Build.targets | 80 ++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 dotnet/Directory.Build.targets

diff --git a/dotnet/Directory.Build.targets b/dotnet/Directory.Build.targets
new file mode 100644
index 000000000..5f8f89217
--- /dev/null
+++ b/dotnet/Directory.Build.targets
@@ -0,0 +1,80 @@
+<Project>
+  <!--
+    DEVELOPMENT MODE: build against the sibling checkouts instead of the published packages.
+
+    The engines live in separate repos and normally consume each other through NuGet pins
+    (Directory.Packages.props). Fixing a bug that spans two of them used to mean a release in
+    between, or a hand-edited csproj someone had to remember to revert. Dev mode swaps each
+    PhoenixmlDb.* PackageReference for a ProjectReference to the sibling repo's source, so one
+    build sees the working trees of all of them.
+
+    Nothing committed changes when it is switched on or off, so there is nothing to switch back
+    before a commit. Switch it on with ANY of:
+      - a file named .phoenixml-dev in the directory that CONTAINS the repos. That is outside
+        every repo, so it can never be committed:  touch <workspace>/.phoenixml-dev
+      - the environment variable PHOENIXML_DEV=1
+      - dotnet build -p:PhoenixmlDev=true
+    Switch it off by removing it. The next restore picks the change up; no clean is needed.
+
+    It fails closed on the two ways it could leak into a release. Packing in dev mode is an
+    error, because such a package would declare dependencies on whatever the working trees happen
+    to be. Dev mode under CI is also an error, because CI only ever builds what was committed. And
+    a sibling that is not checked out is an error, never a silent fallback to the package.
+
+    This file is identical wherever the engines are consumed: phoenixmldb-xquery, phoenixmldb-xslt,
+    xquery-mcp, xslt-mcp, and xspec's dotnet/ (branch phxspec). Keep the copies in step:
+      diff ../phoenixmldb-xslt/Directory.Build.targets Directory.Build.targets
+  -->
+  <PropertyGroup>
+    <!-- The directory holding the checkouts: the nearest ancestor with phoenixmldb-core in it, so
+         this file works at any depth (xspec keeps its .NET projects in dotnet/). Falls back to
+         the parent directory, which is where the missing-sibling errors will then point. -->
+    <PhoenixmlWorkspace Condition="'$(PhoenixmlWorkspace)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove('$(MSBuildThisFileDirectory)', 'phoenixmldb-core/src/PhoenixmlDb.Core/PhoenixmlDb.Core.csproj'))</PhoenixmlWorkspace>
+    <PhoenixmlWorkspace Condition="'$(PhoenixmlWorkspace)' == ''">$(MSBuildThisFileDirectory)..</PhoenixmlWorkspace>
+    <PhoenixmlWorkspace>$([MSBuild]::NormalizeDirectory('$(PhoenixmlWorkspace)'))</PhoenixmlWorkspace>
+    <PhoenixmlDev Condition="'$(PhoenixmlDev)' == '' and '$(PHOENIXML_DEV)' == '1'">true</PhoenixmlDev>
+    <PhoenixmlDev Condition="'$(PhoenixmlDev)' == '' and Exists('$(PhoenixmlWorkspace).phoenixml-dev')">true</PhoenixmlDev>
+    <PhoenixmlDev Condition="'$(PhoenixmlDev)' == ''">false</PhoenixmlDev>
+    <_PhoenixmlDevCore>$(PhoenixmlWorkspace)phoenixmldb-core/src/PhoenixmlDb.Core/PhoenixmlDb.Core.csproj</_PhoenixmlDevCore>
+    <_PhoenixmlDevXQuery>$(PhoenixmlWorkspace)phoenixmldb-xquery/src/PhoenixmlDb.XQuery/PhoenixmlDb.XQuery.csproj</_PhoenixmlDevXQuery>
+    <_PhoenixmlDevXslt>$(PhoenixmlWorkspace)phoenixmldb-xslt/src/PhoenixmlDb.Xslt/PhoenixmlDb.Xslt.csproj</_PhoenixmlDevXslt>
+  </PropertyGroup>
+
+  <!-- Evaluation-time swap, so restore and build see the same graph. This file is imported
+       after the project body, so the project's own PackageReferences already exist here. -->
+  <ItemGroup Condition="'$(PhoenixmlDev)' == 'true'">
+    <_PhoenixmlDevHitCore Include="@(PackageReference->WithMetadataValue('Identity', 'PhoenixmlDb.Core'))" />
+    <_PhoenixmlDevHitXQuery Include="@(PackageReference->WithMetadataValue('Identity', 'PhoenixmlDb.XQuery'))" />
+    <_PhoenixmlDevHitXslt Include="@(PackageReference->WithMetadataValue('Identity', 'PhoenixmlDb.Xslt'))" />
+
+    <!-- Existing ProjectReferences to the same projects are re-pointed at the canonical sibling
+         path. One reached through a symlink (the conformance project's src/PhoenixmlDb.XQuery)
+         has a different full path, so MSBuild would treat it as a second project that shares
+         the first one's obj directory. -->
+    <_PhoenixmlDevRefCore Include="@(ProjectReference->WithMetadataValue('Filename', 'PhoenixmlDb.Core'))" />
+    <_PhoenixmlDevRefXQuery Include="@(ProjectReference->WithMetadataValue('Filename', 'PhoenixmlDb.XQuery'))" />
+    <_PhoenixmlDevRefXslt Include="@(ProjectReference->WithMetadataValue('Filename', 'PhoenixmlDb.Xslt'))" />
+
+    <PackageReference Remove="@(_PhoenixmlDevHitCore);@(_PhoenixmlDevHitXQuery);@(_PhoenixmlDevHitXslt)" />
+    <ProjectReference Remove="@(_PhoenixmlDevRefCore);@(_PhoenixmlDevRefXQuery);@(_PhoenixmlDevRefXslt)" />
+    <ProjectReference Include="$(_PhoenixmlDevCore)" Condition="'@(_PhoenixmlDevHitCore)@(_PhoenixmlDevRefCore)' != ''" />
+    <ProjectReference Include="$(_PhoenixmlDevXQuery)" Condition="'@(_PhoenixmlDevHitXQuery)@(_PhoenixmlDevRefXQuery)' != ''" />
+    <ProjectReference Include="$(_PhoenixmlDevXslt)" Condition="'@(_PhoenixmlDevHitXslt)@(_PhoenixmlDevRefXslt)' != ''" />
+  </ItemGroup>
+
+  <Target Name="PhoenixmlDevModeCheck" BeforeTargets="Restore;_GenerateRestoreGraphProjectEntry;CollectPackageReferences;Build"
+          Condition="'$(PhoenixmlDev)' == 'true'">
+    <Error Condition="'$(GITHUB_ACTIONS)' == 'true' or '$(CI)' == 'true'"
+           Text="PhoenixmlDev is on under CI. CI builds only what was committed; remove PHOENIXML_DEV / -p:PhoenixmlDev." />
+    <Error Condition="'@(_PhoenixmlDevHitCore)' != '' and !Exists('$(_PhoenixmlDevCore)')"
+           Text="PhoenixmlDev: PhoenixmlDb.Core should come from $(_PhoenixmlDevCore), which does not exist. Check out phoenixmldb-core beside this repo, or switch dev mode off." />
+    <Error Condition="'@(_PhoenixmlDevHitXQuery)' != '' and !Exists('$(_PhoenixmlDevXQuery)')"
+           Text="PhoenixmlDev: PhoenixmlDb.XQuery should come from $(_PhoenixmlDevXQuery), which does not exist. Check out phoenixmldb-xquery beside this repo, or switch dev mode off." />
+    <Error Condition="'@(_PhoenixmlDevHitXslt)' != '' and !Exists('$(_PhoenixmlDevXslt)')"
+           Text="PhoenixmlDev: PhoenixmlDb.Xslt should come from $(_PhoenixmlDevXslt), which does not exist. Check out phoenixmldb-xslt beside this repo, or switch dev mode off." />
+  </Target>
+
+  <Target Name="PhoenixmlDevModeNoPack" BeforeTargets="Pack;GenerateNuspec" Condition="'$(PhoenixmlDev)' == 'true'">
+    <Error Text="PhoenixmlDev is on: refusing to pack. A package built against the sibling working trees would declare dependencies on unreleased source. Switch dev mode off (remove ../.phoenixml-dev and PHOENIXML_DEV) and pack again." />
+  </Target>
+</Project>