DepthReductionFinal

[petiaccja]

Components

Missing port names
Use Binder instead of optional
Don't store input port values as member variables (m_camera, m_suns), query in Execute()
Shader: Don't rewrite all utility function such as creating matrices

Header

Bunch of commented code snippets

Implementation

Factor out binder creation to its own function.
Factor out CSO creation.

Code style

Naming conventions violated:

• cpp/Uniforms
• cpp/InitRenderTarget textures
• cpp/Execute vectors
• shader/Uniforms
• shader/all function names
• shader/local variables
• shader/literally everything is wrong
• shader/one letter variables, like loads, especially in loops
• cpp/vp is not a name, viewProj is