Add snoretoast custom compile script#600
Merged
Merged
Conversation
Collaborator
|
Is there any way to check if it works in development? seems to me like |
Contributor
Author
|
Indeed! The CI build should also be ported to local |
Araxeus
added a commit
to Araxeus/youtube-music
that referenced
this pull request
Feb 13, 2022
This was referenced Jan 6, 2023
Araxeus
added a commit
to Araxeus/youtube-music
that referenced
this pull request
Jan 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #591 and patches SnoreToast to avoid including arbitrary binaries that cannot be verified in the source code - with caching, only the time to fetch from cache is necessary (a few seconds) - once KDE/snoretoast#15 then mikaelbr/node-notifier#375 get merged, this patching won't be necessary anymore.
todo: the Windows build command (
yarn build:win) does not include these patched versions!