fix notification showing appID instead of app name on windows#270
Merged
th-ch merged 7 commits intoMay 16, 2021
Merged
Conversation
th-ch
approved these changes
May 16, 2021
Contributor
th-ch
left a comment
th-ch
left a comment
There was a problem hiding this comment.
Code change looks ok, thanks for the improvement! Merging ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
This sets the appID +
if not in dev mode OR running from portable app -> check the windows startMenu shortcut and fix it if necessary,
(Since this fix works only if shortcut is correctly registered in startMenu)