Skip to content

SDK PR tests never run and aren't required to merge #178

Description

@kirilly

The Pull Request Tests workflow (.github/workflows/pr-test.yml) only triggers on PRs to main, and it has 0 runs in the history, so in practice it hasn't gated anything. Day-to-day work happens on dev branches (the Staging ruleset covers dev), which pr-test never sees.

Two more gaps:

  • The only job that runs is test-basic. The test-live job (the actual integration coverage) is commented out.
  • No ruleset requires a status check (checks=[] everywhere), so pr-test isn't a required check even on main.

Suggested fix

Trigger pr-test on PRs to dev as well as main, decide what to do with the commented-out live tests (restore or delete), and make the check required via a ruleset on the branches you actually merge into.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions