From e281de921b55bc4843fe73e5c26b06625056698e Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 22 Oct 2022 13:32:27 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- experiments/datasets/speech_commands.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/experiments/datasets/speech_commands.py b/experiments/datasets/speech_commands.py index e69b45d..f108f0d 100644 --- a/experiments/datasets/speech_commands.py +++ b/experiments/datasets/speech_commands.py @@ -22,7 +22,26 @@ def download(): os.mkdir(base_loc) urllib.request.urlretrieve('http://download.tensorflow.org/data/speech_commands_v0.02.tar.gz', loc) with tarfile.open(loc, 'r') as f: - f.extractall(base_loc) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, base_loc) def _process_data(intensity_data):