This repository was archived by the owner on Jan 15, 2025. It is now read-only.
remove message hook#13
Open
balanza wants to merge 1 commit into
Open
Conversation
fabriziopapi
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove two commit message behaviors:
I find both more annoying than useful. We can improve them for sure, but IMHO it's not worth the effort.
Why remove Infer Jira issue id from branch, and prepend it to the commit message
IMHO this hook brings no value because:
Furthermore, it is really annoying as the script keeps prepending the id to the commit on every history rewrite (amend, rebase, etc).
Why remove Limit commit message length to 72 characters
While this may work for human-written messages, it often breaks for auto-generated commit messages (like merge commits)