GitHub Community
Top level PR comment thread #8469
Replies: 39 comments 12 replies
|
Enabling threading on top level comments by default would greatly improve to PR commenting experience. |
|
Came looking for someone else saying this, and I'm sad to see the lack of traction it's gotten. This is absolutely my single biggest issue with using GitHub. I've taken to replying to top-level comments on PRs by @ing the person on slack, and attaching my own "top-level" comments to the first line of code. The alternative is to end up filling the PR with unresolvable top-level messages that could represent any number of discussions all mixed in with one another. It's a huge mess, and the excellent way comment threads in the actual code are handled shows that it doesn't need to be like that. |
|
Please add this feature, it's very challenging when people leave questions or thoughts that need a response in top level comments. |
|
This is wonderful idea. Would be happy to see it! |
|
It would be very useful to have discussion threads on top level comments just like we have on file diffs. |
|
I was working with GitLab very long in my previous position. Now moved to GitHub and im somehow shocked that this does not exist. Replying to a comment in a thread style is basically needed everywhere not just in top level RP comments. Its needed in issue comments as well. Please @github-staff have a look! 👀 |
|
awesome, they're working really hard on it! github/roadmap#552 |
|
this also applies to issues or just PRs ? |
|
2022 is about to end now, not sure if the feature can be shipped soon? |
|
It looks like this was bumped to Q2 2023. |
|
It seems it's been moved to "Future" now, so probably low priority. Too bad though, this feature would be great! |
|
FYI that roadmap item is now closed as not planned. "Replying to PR comments is currently in an exploratory phase, so we have removed it from this roadmap while we develop more definition and certainty on our scope and timelines." |
|
Azure DevOps has this feature. Microsoft, please port it to GitHub. |
|
Please add this feature. It really helps to make the PR comment view cleaner. It would also be nice for the "Require conversation resolution before merging" to (optionally) apply to top-level comments |
|
Makes a lot of sense. Often need to provide more general comments, or alternatives that could be considered. |
|
Please add this "feature" (seems more like a bug fix to me though). |
|
So happy to see this on the road map. In addition to the problematic ability to follow the conversations of top level comments the tone of |
|
I see that this issue was moved from Q2 2023 to the Future. What is the reasoning for this? |
|
Please help to support this feature. In my current project, many people can put comments on the PR. It is too difficult to track all the comments and reply to them. |
|
This feature available in gitlab, it so great, so please support add this feature to github. |
|
See also: |
|
Please do this, it would be a major improvement for sure! I miss this from GitLab ;) |
|
It's absurd that this is not a feature :O |
|
Up! |
|
Another aspect of this is the combination of “require conversation resolution” and “auto merge” features would benefit if conversations at the top level of a pull request were also able to be marked resolved. This would allow people to leave actionable feedback and ask that it be resolved before merging. right now this requires you to go find a file to leave that comment on, even if there’s no specific file that it should be left on. |
|
My exact use case! Very annoying coming from Azure DevOps |
|
Totally agree with this having threaded replies for top-level PR comments would make discussions much cleaner. It’s messy when general feedback or questions end up scattered across multiple comments. This feature would definitely improve collaboration. |
|
PR comment threads when |
|
+1 - is there a way to vote for interesting feature requests? |
|
This is one of the top 10 most requested pull request features, and one of the top 40 most upvoted GitHub discussions of all time. It was added to the roadmap, and then removed so that GitHub could "develop more definition and certainty on [their] scope and timelines". Now, over a year later, that scope still hasn't been defined. If scope and timelines are the problem, then I'd like to offer a suggestion: Do whatever is easiest. Port GitHub discussion threads or simply re-use the file-based pull request threads. Right now we can't have an organized conversation, so any kind of thread would be an improvement. I'm certain that GitHub agrees this is an important issue that can be solved, because they've already solved it for discussions and pull request files. If there are still unanswered questions about the scope, look and feel, features, etc., then please jump into the discussion and ask questions. There are 600+ people here to help figure out an answer. |
|
Please do this. Can't believe it doesn't exist. |
|
Is this implemented or planned yet? Coming over from gitlab and can't believe that github doesn't support threading |
|
This would be a great feature, it's hellish if you get two or three threads of conversation going on at the top level of a PR with just block quotes to try and connect things together. It's common to have a discussion that isn't directly related to a specific modified file, like overall direction of the PR, omissions, etc. It's also frustrating because they look so similar to the threaded conversations it feels like there should be a reply box right there. I imagine it confuses users to see reply entries in some places and not others. |
|
Let's make it happen before the apocolyps? |
|
Comments in PRs that aren't related to file(s) need to be threadable (just like comments on files) - currently one has to 'quote reply' to preserve some semblance of context in replies, which creates extra unnecessary noise and is difficult to follow in the disjointed list of comments that can happen in normal PR discussions. Additionally, these types of comments need to be 'resolvable' (again, just like comments on files!) to help clean up resolved discussions. P.S. I find it unbelievable this obviously needed feature still isn't implemented nearly 6 years after its initial request. 🙄 |
|
Just tell claude to implement it and release it tomorrow this is insane. |
|
Feels like GH will sooner implement naming "Lake America" than fix this clear lack of functionality. |
|
if this is somehow a complicated change the system is completely screwed up. |
and others
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I wish there was a way to create a thread on top-level pull request review comments.
Often times I find I want to add a general comment that is not related to any specific line of code. For example, like elastic/elastic-charts#1475 (review). I have left comments on specific lines of code to be addressed but then I have a general comment on top of those.
The issue is, if this top-level comment is actionable such that I am requesting the author to change some code in a general sense or it might just be a general question that I would like a response to, there is not a great way to respond to this comment.
Currently, the best approach is something like elastic/elastic-charts#1475 (comment), where we use so called Quote reply via block-quotes (i.e.
>) to address each part of the top-level comment in a new top-level comment.The issue with this is that it creates a disconnect between the original comment and the response, as well as creating noise on the pr with several top-level comments. This issue is not as important with issues (non-prs) because the top-level is often a back and forth response with a single idea where there is not often tangential ideas/threads active at the same time, though could be useful in some cases.
An ideal solution would be to enable a thread for top-level pr review comments. Maybe by default it is as it is currently, but with an option to create a thread off of the comment.
All reactions