Replies: 2 comments 1 reply
|
See also: FormingWorlds/MORS#33, https://github.com/orgs/FormingWorlds/discussions/590, #591 |
0 replies
|
Yes, I think moving the data download functionality into its own repository would be useful for the reasons you outline; even having this pip-installable might be useful. I think the best way to go for now is to first merge PR #591, and then tackle this as a next step. |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Several of the PROTEUS ecosystem models depend on data obtained from online sources: Zenodo and OSF, at the moment. This means they will each need code for downloading these data. At the moment, these are implemented separately for each repo.
However, we could consider creating a generic
FormingWorlds/resource_getterrepository for obtaining data (name TBD). This repo would then be imported by each of the FWL models, avoiding code duplication. It also means we can create tests for these utilities, rather than wrapping them under the 'physics' part of the models.Thoughts/suggestions/ideas?
@timlichtenberg @stuitje @MarijnJ0 @EmmaPostolec @planetmariana
All reactions