network: Remove irrelevant TODO

stephenfin · stephenfin · commit b75f741fb602 · 2026-05-21T15:28:51.000+01:00
I think the intention here was to use attr-style access rather than
converting to a dict, but we're unlikely to do this at this point.
Just drop the TODOs as they're just noise at this point.

Change-Id: Id66fb87ea303f5dda84ebf8de244b81ea11735a5
Signed-off-by: Stephen Finucane &lt;stephenfin@redhat.com&gt;
diff --git a/openstackclient/network/v2/address_scope.py b/openstackclient/network/v2/address_scope.py
@@ -61,8 +61,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(rtheis): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateAddressScope(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create a new Address Scope")
 
@@ -156,8 +154,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(yanxing'an): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListAddressScope(command.Lister):
     _description = _("List address scopes")
 
@@ -253,8 +249,6 @@ def take_action(
         )
 
 
-# TODO(rtheis): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetAddressScope(common.NeutronCommandWithExtraArgs):
     _description = _("Set address scope properties")
 
diff --git a/openstackclient/network/v2/floating_ip.py b/openstackclient/network/v2/floating_ip.py
@@ -231,9 +231,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
 
 
 class ListFloatingIP(command.Lister):
-    # TODO(songminglong): Use SDK resource mapped attribute names once
-    # the OSC minimum requirements include SDK 1.0
-
     _description = _("List floating IP(s)")
 
     def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
diff --git a/openstackclient/network/v2/ip_availability.py b/openstackclient/network/v2/ip_availability.py
@@ -36,8 +36,6 @@ def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
     )
 
 
-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once
-# the OSC minimum requirements include SDK 1.0.
 class ListIPAvailability(command.Lister):
     _description = _("List IP availability for network")
 
diff --git a/openstackclient/network/v2/network.py b/openstackclient/network/v2/network.py
@@ -208,8 +208,6 @@ def _add_additional_network_options(parser: argparse.ArgumentParser) -> None:
     )
 
 
-# TODO(sindhu): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateNetwork(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create new network")
 
@@ -439,8 +437,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(sindhu): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListNetwork(command.Lister):
     _description = _("List networks")
 
@@ -671,8 +667,6 @@ def take_action(
         )
 
 
-# TODO(sindhu): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetwork(common.NeutronCommandWithExtraArgs):
     _description = _("Set network properties")
 
diff --git a/openstackclient/network/v2/network_agent.py b/openstackclient/network/v2/network_agent.py
@@ -190,8 +190,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(huanxuan): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListNetworkAgent(command.Lister):
     _description = _("List network agents")
     _supported_agents = {
@@ -378,8 +376,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             client.remove_router_from_agent(agent, router)
 
 
-# TODO(huanxuan): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetworkAgent(command.Command):
     _description = _("Set network agent properties")
 
diff --git a/openstackclient/network/v2/network_auto_allocated_topology.py b/openstackclient/network/v2/network_auto_allocated_topology.py
@@ -63,8 +63,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateAutoAllocatedTopology(command.ShowOne):
     _description = _("Create the  auto allocated topology for project")
 
@@ -130,8 +128,6 @@ def take_action(
         return (columns, data)
 
 
-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class DeleteAutoAllocatedTopology(command.Command):
     _description = _("Delete auto allocated topology for project")
 
diff --git a/openstackclient/network/v2/network_flavor.py b/openstackclient/network/v2/network_flavor.py
@@ -92,8 +92,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
         )
 
 
-# TODO(dasanind): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateNetworkFlavor(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create new network flavor")
 
@@ -247,8 +245,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
         )
 
 
-# TODO(dasanind): Use only the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetworkFlavor(common.NeutronCommandWithExtraArgs):
     _description = _("Set network flavor properties")
 
diff --git a/openstackclient/network/v2/network_flavor_profile.py b/openstackclient/network/v2/network_flavor_profile.py
@@ -55,8 +55,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(ndahiwade): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateNetworkFlavorProfile(
     command.ShowOne, common.NeutronCommandWithExtraArgs
 ):
@@ -194,8 +192,6 @@ def take_action(
         )
 
 
-# TODO(ndahiwade): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetworkFlavorProfile(common.NeutronCommandWithExtraArgs):
     _description = _("Set network flavor profile properties")
 
diff --git a/openstackclient/network/v2/network_meter.py b/openstackclient/network/v2/network_meter.py
@@ -64,8 +64,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateMeter(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create network meter")
 
@@ -119,8 +117,6 @@ def take_action(
         return (display_columns, data)
 
 
-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class DeleteMeter(command.Command):
     _description = _("Delete network meter")
 
diff --git a/openstackclient/network/v2/network_qos_policy.py b/openstackclient/network/v2/network_qos_policy.py
@@ -82,8 +82,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateNetworkQosPolicy(
     command.ShowOne, common.NeutronCommandWithExtraArgs
 ):
@@ -186,8 +184,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(abhiraut): Use only the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListNetworkQosPolicy(command.Lister):
     _description = _("List QoS policies")
 
@@ -248,8 +244,6 @@ def take_action(
         )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetworkQosPolicy(common.NeutronCommandWithExtraArgs):
     _description = _("Set QoS policy properties")
 
diff --git a/openstackclient/network/v2/network_rbac.py b/openstackclient/network/v2/network_rbac.py
@@ -95,8 +95,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateNetworkRBAC(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create network RBAC policy")
 
@@ -321,8 +319,6 @@ def take_action(
         )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetNetworkRBAC(common.NeutronCommandWithExtraArgs):
     _description = _("Set network RBAC policy properties")
 
diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
@@ -189,8 +189,6 @@ def _get_attrs(
     if 'network' in parsed_args and parsed_args.network is not None:
         attrs['network_id'] = parsed_args.network
     if 'project' in parsed_args and parsed_args.project is not None:
-        # TODO(singhj): since 'project' logic is common among
-        # router, network, port etc., maybe move it to a common file.
         identity_client = client_manager.identity
         project_id = identity_common.find_project(
             identity_client,
@@ -447,8 +445,6 @@ def _add_updatable_args(
     )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 def _convert_address_pairs(
     parsed_args: argparse.Namespace,
 ) -> list[dict[str, Any]]:
@@ -785,8 +781,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(abhiraut): Use only the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListPort(command.Lister):
     _description = _("List ports")
 
@@ -984,8 +978,6 @@ def take_action(
         )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetPort(common.NeutronCommandWithExtraArgs):
     _description = _("Set port properties")
 
@@ -1262,8 +1254,6 @@ def take_action(
         return (display_columns, data)
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class UnsetPort(common.NeutronUnsetCommandWithExtraArgs):
     _description = _("Unset port properties")
 
diff --git a/openstackclient/network/v2/router.py b/openstackclient/network/v2/router.py
@@ -478,8 +478,6 @@ def take_action(
         return (display_columns, data)
 
 
-# TODO(yanxing'an): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateRouter(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create a new router")
 
@@ -713,8 +711,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(yanxing'an): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListRouter(command.Lister):
     _description = _("List routers")
 
@@ -919,8 +915,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
         )
 
 
-# TODO(yanxing'an): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetRouter(common.NeutronCommandWithExtraArgs):
     _description = _("Set router properties")
 
diff --git a/openstackclient/network/v2/security_group.py b/openstackclient/network/v2/security_group.py
@@ -105,8 +105,6 @@ def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
     )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateSecurityGroup(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create a new security group")
 
@@ -223,8 +221,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(rauta): Use the SDK resource mapped attribute names once
-# the OSC minimum requirements include SDK 1.0.
 class ListSecurityGroup(command.Lister):
     _description = _("List security groups")
     FIELDS_TO_RETRIEVE = [
diff --git a/openstackclient/network/v2/security_group_rule.py b/openstackclient/network/v2/security_group_rule.py
@@ -38,8 +38,6 @@ def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
     )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateSecurityGroupRule(
     command.ShowOne, common.NeutronCommandWithExtraArgs
 ):
diff --git a/openstackclient/network/v2/subnet.py b/openstackclient/network/v2/subnet.py
@@ -302,8 +302,6 @@ def _get_attrs(
     return attrs
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateSubnet(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create a subnet")
 
@@ -490,8 +488,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(abhiraut): Use only the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListSubnet(command.Lister):
     _description = _("List subnets")
 
@@ -664,8 +660,6 @@ def take_action(
         )
 
 
-# TODO(abhiraut): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetSubnet(common.NeutronCommandWithExtraArgs):
     _description = _("Set subnet properties")
 
diff --git a/openstackclient/network/v2/subnet_pool.py b/openstackclient/network/v2/subnet_pool.py
@@ -156,8 +156,6 @@ def _add_default_options(parser: argparse.ArgumentParser) -> None:
     )
 
 
-# TODO(rtheis): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class CreateSubnetPool(command.ShowOne, common.NeutronCommandWithExtraArgs):
     _description = _("Create subnet pool")
 
@@ -270,8 +268,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:
             raise exceptions.CommandError(msg)
 
 
-# TODO(rtheis): Use only the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class ListSubnetPool(command.Lister):
     _description = _("List subnet pools")
 
@@ -400,8 +396,6 @@ def take_action(
         )
 
 
-# TODO(rtheis): Use the SDK resource mapped attribute names once the
-# OSC minimum requirements include SDK 1.0.
 class SetSubnetPool(common.NeutronCommandWithExtraArgs):
     _description = _("Set subnet pool properties")
 

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,6 @@ def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:`
`36`	`36`	`)`
`37`	`37`
`38`	`38`
`39`		`-# TODO(ankur-gupta-f): Use the SDK resource mapped attribute names once`
`40`		`-# the OSC minimum requirements include SDK 1.0.`
`41`	`39`	`class ListIPAvailability(command.Lister):`
`42`	`40`	`_description = _("List IP availability for network")`
`43`	`41`
Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:`
`92`	`92`	`)`
`93`	`93`
`94`	`94`
`95`		`-# TODO(dasanind): Use the SDK resource mapped attribute names once the`
`96`		`-# OSC minimum requirements include SDK 1.0.`
`97`	`95`	`class CreateNetworkFlavor(command.ShowOne, common.NeutronCommandWithExtraArgs):`
`98`	`96`	`_description = _("Create new network flavor")`
`99`	`97`
`@@ -247,8 +245,6 @@ def take_action(self, parsed_args: argparse.Namespace) -> None:`
`247`	`245`	`)`
`248`	`246`
`249`	`247`
`250`		`-# TODO(dasanind): Use only the SDK resource mapped attribute names once the`
`251`		`-# OSC minimum requirements include SDK 1.0.`
`252`	`248`	`class SetNetworkFlavor(common.NeutronCommandWithExtraArgs):`
`253`	`249`	`_description = _("Set network flavor properties")`
`254`	`250`