diff --git a/src/scanners/machine_uuid_scanner.go b/src/scanners/machine_uuid_scanner.go index a064f122c..df26ac587 100644 --- a/src/scanners/machine_uuid_scanner.go +++ b/src/scanners/machine_uuid_scanner.go @@ -32,7 +32,7 @@ var ( FailureUUID = strfmt.UUID("deaddead-dead-dead-dead-deaddeaddead") ) -var unknownSerialCases = []string{"", util.UNKNOWN, "none", "(none)", "-", +var unknownSerialCases = []string{"", util.UNKNOWN, "none", "(none)", "-", "empty", SerialUnspecifiedBaseBoardString, SerialUnspecifiedSystemString, SerialDefaultString, SerialNotSpecified, strings.ToLower(SerialProliantGen11)} var unknownUuidCases = []string{"", util.UNKNOWN, ZeroesUUID, KaloomUUID} diff --git a/src/scanners/machine_uuid_scanner_test.go b/src/scanners/machine_uuid_scanner_test.go index fcde44a86..40c83a315 100644 --- a/src/scanners/machine_uuid_scanner_test.go +++ b/src/scanners/machine_uuid_scanner_test.go @@ -82,6 +82,12 @@ var _ = Describe("Machine uuid test", func() { id := ReadId(serialDiscovery, dependencies) Expect(id).To(Equal(toUUID("856f4f9c-3c08-4d97-8ec7-ea0ad7d4cadf"))) }) + It("empty string serial", func() { + serialDiscovery.On("Baseboard").Return(&ghw.BaseboardInfo{SerialNumber: "empty"}, nil).Once() + serialDiscovery.On("Product").Return(&ghw.ProductInfo{UUID: TestUuid}, nil) + id := ReadId(serialDiscovery, dependencies) + Expect(id).To(Equal(toUUID(TestUuid))) + }) tests := []struct { useCase string