From 594f414e74e3842a6091119217847d21c7dee8ff Mon Sep 17 00:00:00 2001 From: martinfrancois Date: Tue, 11 Aug 2026 20:14:52 +0200 Subject: [PATCH] DependencyManagementDependencyRequiresVersion: add failing test for versionless entries under profiles Pins that a coordinates-only dependencyManagement entry inside profiles/profile is left untouched, because isManagedDependencyTag() only matches the top-level path. Marked known-failing with @Disabled; inherited limitation disclosed in PR #8445. --- .../ManagedDependencyRequiresVersionTest.java | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/rewrite-maven/src/test/java/org/openrewrite/maven/cleanup/ManagedDependencyRequiresVersionTest.java b/rewrite-maven/src/test/java/org/openrewrite/maven/cleanup/ManagedDependencyRequiresVersionTest.java index ec129a9c9c5..1408e2d5e82 100644 --- a/rewrite-maven/src/test/java/org/openrewrite/maven/cleanup/ManagedDependencyRequiresVersionTest.java +++ b/rewrite-maven/src/test/java/org/openrewrite/maven/cleanup/ManagedDependencyRequiresVersionTest.java @@ -15,6 +15,7 @@ */ package org.openrewrite.maven.cleanup; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.openrewrite.Issue; import org.openrewrite.test.RewriteTest; @@ -53,4 +54,54 @@ void dependencyManagementDependencyRequiresVersion() { ) ); } + + @Disabled("isManagedDependencyTag() only matches /project/dependencyManagement, so versionless entries under are never removed; see https://github.com/openrewrite/rewrite/pull/8445") + @Test + void profileDependencyManagementDependencyRequiresVersion() { + rewriteRun( + spec -> spec.recipe(new DependencyManagementDependencyRequiresVersion()), + pomXml( + """ + + test + test + 1.0-SNAPSHOT + + + + com.fasterxml.jackson.core + jackson-databind + + + + + + example + + + + com.fasterxml.jackson.core + jackson-core + + + + + + + """, + """ + + test + test + 1.0-SNAPSHOT + + + example + + + + """ + ) + ); + } }