Short circuit the applicability checks

Inline the conditions into their `if` statements, such that the cheaper
checks can reject a declaration before the more expensive ones run.

Author: timtebeek

src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForGenericMethodInvocations.java

@@ -58,10 +58,9 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations v
             }
 
             // Recipe specific
-            boolean isPrimitive = DeclarationCheck.isPrimitive(vd);
-            boolean usesNoGenerics = !DeclarationCheck.useGenerics(vd);
-            boolean usesTernary = DeclarationCheck.initializedByTernary(vd);
-            if (isPrimitive || usesTernary || usesNoGenerics) {
+            if (DeclarationCheck.isPrimitive(vd) ||
+                    DeclarationCheck.initializedByTernary(vd) ||
+                    !DeclarationCheck.useGenerics(vd)) {
                 return vd;
             }
 
@@ -73,9 +72,7 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations v
             J.MethodInvocation invocation = (J.MethodInvocation) originalInitializer.unwrap();
 
             // If no type parameters and no arguments are present, we assume the type is too hard to determine
-            boolean hasNoTypeParams = invocation.getTypeParameters() == null;
-            boolean argumentsEmpty = allArgumentsEmpty(invocation);
-            if (hasNoTypeParams && argumentsEmpty) {
+            if (invocation.getTypeParameters() == null && allArgumentsEmpty(invocation)) {
                 return vd;
             }
 

src/main/java/org/openrewrite/java/migrate/lang/var/UseVarForObject.java

@@ -56,13 +56,12 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations v
                 return vd;
             }
 
-            boolean isPrimitive = DeclarationCheck.isPrimitive(vd);
-            boolean usesGenerics = DeclarationCheck.useGenerics(vd);
-            boolean usesTernary = DeclarationCheck.initializedByTernary(vd);
             Expression initializer = vd.getVariables().get(0).getInitializer();
-            boolean usesArrayInitializer = initializer instanceof J.NewArray;
-            boolean initializedByStaticMethod = DeclarationCheck.initializedByStaticMethod(initializer);
-            if (isPrimitive || usesGenerics || usesTernary || usesArrayInitializer || initializedByStaticMethod ||
+            if (DeclarationCheck.isPrimitive(vd) ||
+                    DeclarationCheck.useGenerics(vd) ||
+                    DeclarationCheck.initializedByTernary(vd) ||
+                    initializer instanceof J.NewArray ||
+                    DeclarationCheck.initializedByStaticMethod(initializer) ||
                     DeclarationCheck.initializedByUnresolvableGenericMethod(initializer)) {
                 return vd;
             }