Support password protected/encrypted files

[marcel263]

The app v 3.26 refused to open password-protected xlsx file. It gave a warning "unsupported file". LibreOffice desktop would open it, prompting for password.

[andiwand]

@TomTasche do you know if this runs the core backend or the online one?

[TomTasche]

This is online, we don't parse XLSX locally yet: https://github.com/opendocument-app/OpenDocument.droid/blob/main/app/src/main/java/at/tomtasche/reader/background/OoxmlLoader.java#L31

[marcel263]

Apologies I assumed the app would support various types of OpenDocument formats

[andiwand]

I think this should work @marcel263 - does this only show up for a single file or all of the encrypted XLSX? In case this only happens for a specific file would you be able to share it with us?

[andiwand]

encrypted.xlsx password

Could not reproduce the problem in core but the file does not load correctly in the app.
Tested with 3.10.4

I guess that is a workflow problem in the android code @TomTasche

[marcel263]

I think this should work @marcel263 - does this only show up for a single file or all of the encrypted XLSX? In case this only happens for a specific file would you be able to share it with us?

Dear, the attached file was created with Calc 7.6.6.3 on Linux x86_64. It was password-protected with "password". It reproduces the app's issue of not opening.
Untitled 1.xlsx

[andiwand]

@TomTasche do you know why this might happen?

[TomTasche]

I couldn't remember how we handle XLSX so I had to dig it up myself: we upload them to our own server, which uses the LibreOffice CLI to convert the file to PDF and then return that PDF to the client for rendering: https://github.com/opendocument-app/OpenDocument.server/blob/master/index.js

Looks like I simply never thought of password-protected files while implementing the server... We would need to add a server response accordingly and handle that on the client to ask for the password.

[andiwand]

Alternatively we could use core for encrypted files? Although this requires some logic to handle in which case to use what

[TomTasche]

@andiwand I see opendocument-app/OpenDocument.core#267 is closed already, so how about we enable XLSX core support in the app by default?

[andiwand]

@TomTasche I think XLSX is not quite there with the formatting but might be better than showing nothing