From 6b4e6dd2effbcaec1a0c5de4fdee4a086ecb304c Mon Sep 17 00:00:00 2001 From: zeevdr Date: Wed, 10 Jun 2026 14:14:20 +0300 Subject: [PATCH] fix: correct supported server version floor to v0.8.0 SUPPORTED_SERVER_VERSION advertised >=0.3.0,<1.0.0, but the SDK's proto stubs already target decree v0.8.0+. The stale floor told users that servers as old as v0.3.0 were supported when they are not. Bump the source field in sdk/pyproject.toml, regenerate _constants.py, update README, sdk/README, and docs/index, and realign the tests that asserted the old default range. Add a changelog entry. Co-Authored-By: Claude Refs opendecree/decree#906 --- CHANGELOG.md | 8 ++++++++ README.md | 2 +- docs/index.md | 2 +- sdk/README.md | 2 +- sdk/pyproject.toml | 2 +- sdk/src/opendecree/_constants.py | 2 +- sdk/tests/test_client.py | 2 +- sdk/tests/test_compat.py | 6 +++--- sdk/tests/test_version.py | 2 +- 9 files changed, 18 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 06cb4c6..9786534 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). +## [Unreleased] + +### Fixed + +- `SUPPORTED_SERVER_VERSION` corrected to `>=0.8.0,<1.0.0` (was `>=0.3.0,<1.0.0`). The + advertised minimum server version was stale — the SDK's proto stubs already target + v0.8.0+. README and docs updated to match. Aligns with the TypeScript SDK. + ## [0.3.0a1] - 2026-04-27 ### Added diff --git a/README.md b/README.md index cbf6ef7..0adddfa 100644 --- a/README.md +++ b/README.md @@ -105,7 +105,7 @@ gh attestation verify opendecree-*.whl --repo opendecree/decree-python ## Requirements - Python 3.11+ -- A running OpenDecree server (v0.3.0+) +- A running OpenDecree server (v0.8.0 – v0.x, pre-1.0) ## Questions? diff --git a/docs/index.md b/docs/index.md index 75561eb..dc2133a 100644 --- a/docs/index.md +++ b/docs/index.md @@ -19,7 +19,7 @@ pip install opendecree ## Requirements - Python 3.11+ -- A running OpenDecree server (v0.3.0+) +- A running OpenDecree server (v0.8.0 – v0.x, pre-1.0) ## Quick Start diff --git a/sdk/README.md b/sdk/README.md index c6e4937..c179968 100644 --- a/sdk/README.md +++ b/sdk/README.md @@ -78,7 +78,7 @@ This package is fully typed. It ships a `py.typed` marker and `.pyi` stub files ## Requirements - Python 3.11+ -- A running OpenDecree server (v0.3.0+) +- A running OpenDecree server (v0.8.0 – v0.x, pre-1.0) ## License diff --git a/sdk/pyproject.toml b/sdk/pyproject.toml index 4191316..20803e3 100644 --- a/sdk/pyproject.toml +++ b/sdk/pyproject.toml @@ -105,4 +105,4 @@ omit = ["src/opendecree/_generated/*"] fail_under = 95 [tool.opendecree] -supported_server_version = ">=0.3.0,<1.0.0" +supported_server_version = ">=0.8.0,<1.0.0" diff --git a/sdk/src/opendecree/_constants.py b/sdk/src/opendecree/_constants.py index bdb571c..a917f5e 100644 --- a/sdk/src/opendecree/_constants.py +++ b/sdk/src/opendecree/_constants.py @@ -1,2 +1,2 @@ # Generated by build/gen-constants.py — do not edit manually. -SUPPORTED_SERVER_VERSION = ">=0.3.0,<1.0.0" +SUPPORTED_SERVER_VERSION = ">=0.8.0,<1.0.0" diff --git a/sdk/tests/test_client.py b/sdk/tests/test_client.py index d75ed3c..38450cc 100644 --- a/sdk/tests/test_client.py +++ b/sdk/tests/test_client.py @@ -69,7 +69,7 @@ def test_import(self): def test_version_constants(self): assert opendecree.__version__ - assert opendecree.SUPPORTED_SERVER_VERSION == ">=0.3.0,<1.0.0" + assert opendecree.SUPPORTED_SERVER_VERSION == ">=0.8.0,<1.0.0" assert opendecree.PROTO_VERSION == "v1" diff --git a/sdk/tests/test_compat.py b/sdk/tests/test_compat.py index da8ab21..acfb9c7 100644 --- a/sdk/tests/test_compat.py +++ b/sdk/tests/test_compat.py @@ -107,8 +107,8 @@ def test_dev_version_skips_check(): def test_uses_default_range(): - # Default is SUPPORTED_SERVER_VERSION = ">=0.3.0,<1.0.0" - check_version_compatible("0.5.0") # should not raise + # Default is SUPPORTED_SERVER_VERSION = ">=0.8.0,<1.0.0" + check_version_compatible("0.9.0") # should not raise # --- fetch_server_version --- @@ -193,7 +193,7 @@ def test_client_check_compatibility_passes(): client = ConfigClient.__new__(ConfigClient) client._timeout = 5.0 - client._server_version = ServerVersion(version="0.3.1", commit="abc") + client._server_version = ServerVersion(version="0.9.0", commit="abc") client._version_stub = MagicMock() client._version_pb2 = MagicMock() diff --git a/sdk/tests/test_version.py b/sdk/tests/test_version.py index 7dfd30e..e078aaf 100644 --- a/sdk/tests/test_version.py +++ b/sdk/tests/test_version.py @@ -12,7 +12,7 @@ def test_version(): def test_supported_server_version(): - assert opendecree.SUPPORTED_SERVER_VERSION == ">=0.3.0,<1.0.0" + assert opendecree.SUPPORTED_SERVER_VERSION == ">=0.8.0,<1.0.0" def test_proto_version():