Validator fails final page of all data feeds

[thill-odi]

The validator appears to be broken, automatically failing the final page of all feeds apparently on the grounds that the data items are missing attributes (which they are, as by definition the final page doesn't have any items).

See for example:

• https://www.englandsquash.com/public/v1/sessions?afterTimestamp=24834&afterId=24475
• https://opendata.leisurecloud.live/api/feeds/NottinghamCC-live-session-series?afterTimestamp=66790919&afterId=CRES00007249

[thill-odi]

Possibly related to 0628cb8#diff-803e77a1fdc85c50d977e0f291a5886f958fdc2566557bbcba21aac7bf96d2e3

@nickevansuk - thoughts?

[nickevansuk]

@thill-odi are you able to share the exact script that you ran that created this error, and the error itself. For England Squash the error they were seeing (openactive/data-catalogs#12 (comment)) was related to a bug in the test suite (Reference Implementation hasn't yet been updated to use Events - this outstanding PR - so Events testing is still buggy)

[thill-odi]

No script - this is testing via the front-end (https://validator.openactive.io/) - though I noticed the issue because attempting to add dataset sites to the data catalog failed the validation check.

[nickevansuk]

Can't seem to reproduce via https://validator.openactive.io/rpde? Could you possibly provide the steps?

I wonder if they might be separate issues...

[thill-odi]

Steps:

1. Go to the end of the RPDE feed (this may be why you can't reproduce the error - the feeds have been updated, meaning the links given when I opened the issue are no longer the last page)
2. Take the URL of the last page and paste it into the RPDE validator - you'll get a warning that no deleted items are detected
3. Take the URL of the last page and paste it into the URL field at https://validator.openactive.io/
4. The validator correctly detects 'RPDE Opportunity feed' mode, but yields errors owing to absent @type and @context information

[lukehesluke]

The Data Model Validator issue has been moved here: openactive/data-model-validator#443

[lukehesluke]

I'm closing this issue as the Data Model Validator aspect has been raised separately and the only issue with RPDE Validator is a warning that no deleted items are detected, which I think is acceptable