MXWAR-89: integrate provisioning entries list API#118
Conversation
📝 WalkthroughWalkthroughThis PR adds provisioning entry creation functionality and converts the existing provisioning entries list to live API-backed pagination. A new ChangesProvisioning Entries Create and List Enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/accounting/provisioning-entries/ProvisioningEntries.tsx (1)
91-96: 💤 Low valueClient-side filtering only applies to the current page.
The
searchTermfilter operates on the fetched page data, so users won't see matches from other pages. If server-side filtering bycreatedUseris supported by the API, consider passing it as a query parameter for more complete results.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/accounting/provisioning-entries/ProvisioningEntries.tsx` around lines 91 - 96, The client-side search currently filters only the currently fetched page because filtered and visibleRows operate on entries (the current page) using searchTerm; update the data-fetch flow to apply searchTerm on the server instead of filtering locally — e.g., pass searchTerm (createdUser) as a query param when fetching entries so the API returns paginated results already filtered, then remove or bypass the local filtered/visibleRows logic (variables: filtered, visibleRows, entries, searchTerm, totalPages, itemsPerPage) and ensure total is driven by the server’s filtered count to keep pagination accurate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/pages/accounting/provisioning-entries/ProvisioningEntries.tsx`:
- Around line 91-96: The client-side search currently filters only the currently
fetched page because filtered and visibleRows operate on entries (the current
page) using searchTerm; update the data-fetch flow to apply searchTerm on the
server instead of filtering locally — e.g., pass searchTerm (createdUser) as a
query param when fetching entries so the API returns paginated results already
filtered, then remove or bypass the local filtered/visibleRows logic (variables:
filtered, visibleRows, entries, searchTerm, totalPages, itemsPerPage) and ensure
total is driven by the server’s filtered count to keep pagination accurate.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8771aa26-c6b1-4d94-a07e-21b60caafa8c
📒 Files selected for processing (3)
src/pages/accounting/provisioning-entries/CreateProvisioningEntry.tsxsrc/pages/accounting/provisioning-entries/ProvisioningEntries.tsxsrc/router/AppRoutes.tsx
|
Hi @alberto-art3ch @IOhacker 👋 |
Jira : MXWAR-89
Description
This PR integrates the Provisioning Entries listing flow with the backend API and introduces the initial Create Provisioning Entry page and routing structure.
The update improves the accounting provisioning workflow by enabling API-driven rendering and preparing the UI flow for provisioning entry creation.
Screenshots, if any
before
After
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
CONTRIBUTING.md.Summary by CodeRabbit
Release Notes