From 442cf3065ea4421076d40e9700cea502163838c9 Mon Sep 17 00:00:00 2001 From: Kevin Cui Date: Wed, 24 Jun 2026 01:29:17 -0400 Subject: [PATCH] fix(about): drop stale swift-markdown-ui acknowledgement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The app stopped depending on swift-markdown-ui once the update window began parsing release notes itself via AttributedString(markdown:), but the Acknowledgements sheet still credited it — showing users a library that ships nowhere in the build. Remove the entry from the credits list and sync the two docs that described it: DESIGN.md's acknowledgements rundown and RELEASING.md's now-false claim that the update window renders with swift-markdown-ui (it uses its own parser). Signed-off-by: Kevin Cui --- Sources/LockIME/UI/AboutView.swift | 1 - docs/DESIGN.md | 4 ++-- docs/RELEASING.md | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Sources/LockIME/UI/AboutView.swift b/Sources/LockIME/UI/AboutView.swift index e5b2876..bb0723f 100644 --- a/Sources/LockIME/UI/AboutView.swift +++ b/Sources/LockIME/UI/AboutView.swift @@ -87,7 +87,6 @@ struct AcknowledgementsView: View { private let libraries: [Library] = [ .init(name: "Sparkle", license: "Sparkle License", url: URL(string: "https://github.com/sparkle-project/Sparkle")!), - .init(name: "swift-markdown-ui", license: "MIT License", url: URL(string: "https://github.com/gonzalezreal/swift-markdown-ui")!), .init(name: "KeyboardShortcuts", license: "MIT License", url: URL(string: "https://github.com/sindresorhus/KeyboardShortcuts")!), .init(name: "PermissionFlow", license: "MIT License", url: URL(string: "https://github.com/jaywcjlove/PermissionFlow")!), ] diff --git a/docs/DESIGN.md b/docs/DESIGN.md index 182a7e4..539220a 100644 --- a/docs/DESIGN.md +++ b/docs/DESIGN.md @@ -216,8 +216,8 @@ Background `.regularMaterial`. Rhythm: 28 top · icon **128** (`NSApp.applicatio · 14 · name `.title` semibold · 2 · "Version x (y)" `.callout .secondary` selectable · 12 · tagline `.subheadline .secondary` · 14 · links row · Spacer · copyright `.caption .tertiary` · 20 bottom. Links (`.buttonStyle(.link)`): GitHub, -Website, Acknowledgements (sheet listing Sparkle / swift-markdown-ui / -KeyboardShortcuts licenses). +Website, Acknowledgements (sheet listing Sparkle / KeyboardShortcuts / +PermissionFlow licenses). ### 4.4 Update window — Apple Software Update parity Fixed **540×480**, non-reflowing across phases. Header: **real app icon 52pt** diff --git a/docs/RELEASING.md b/docs/RELEASING.md index dd767d5..4e3b584 100644 --- a/docs/RELEASING.md +++ b/docs/RELEASING.md @@ -172,7 +172,7 @@ that file to the zip by basename and embeds it inline as a CDATA `` (`--embed-release-notes` is required — markdown notes are not auto-embedded the way HTML fragments are), so the notes travel with the appcast and need no hosting. The update window renders that -markdown natively with swift-markdown-ui — embedding **markdown, not a +markdown natively with its own parser — embedding **markdown, not a pre-rendered HTML fragment**, which that view would show as raw tags. The same file is reused verbatim as the GitHub Release `body`, so the Release page and the update window can never disagree.