finding(components): ToggleGroupItem.icon is declared in types but no renderer reads it — authored icons render nothing

[yinlianghui]

Measured while fixing #4624 (PR #4630). Filed unassigned. Duplicate-searched (keyword + ToggleGroupItem + the renderer path): no open issue covers it.

The finding

packages/types/src/disclosure.ts:131 declares an icon slot on toggle-group items:

export interface ToggleGroupItem {
  value: string;
  label: string;
  icon?: string;
  disabled?: boolean;
}

The renderer never reads it. packages/components/src/renderers/disclosure/toggle-group.tsx:33-37 maps items to:

{schema.items?.map((item, idx) => (
  {/* value and aria-label and label only */}
))}

Grepping icon across both that renderer and packages/components/src/ui/toggle-group.tsx returns nothing. disabled is declared and unread there too.

Impact

Dormant rather than breaking: an author who declares icon gets a correctly rendered toggle group with the icon silently dropped. Nothing goes red and nothing is misreported.

Concretely, examples/schema-catalog/src/schemas/components-disclosure-toggle-group/with-labels.json authors icon on all three items. PR #4630 fixes that entry's root type and deliberately KEEPS the icon keys, because they are declared fields rather than the entry inventing something — but the catalog is the corpus AI authoring tools retrieve from, so it is currently teaching a key that does nothing.

Options

1. Implement it — render the icon alongside the label in ToggleGroupItem.
2. Retire the declaration if there is no business pull for icon-bearing toggle items.

Either resolves it; leaving a declared-but-unread field is the state worth not keeping. Related class: #4631.

Refs #4624, PR #4630.

---

Generated by Claude Code

[yinlianghui]

First-touch grading (seat repo:objectui, session session_01RnQd8iMMUwXQEV1crFmQiQ, round 1, 2026-08-14): promoted — finding → pm:queue, type Bug (a declared field the renderer provably never reads violates the declared contract: authored icons silently render nothing).

Dispatch scope when picked up: enforce-or-remove. Default direction is retire the icon declaration (zero measured pull; consistent with the platform's declared=enforced doctrine) — implement rendering instead only if measurement finds real consumers authoring it beyond the single catalog entry. disabled on the same interface was measured unread in the same files — settle it in the same pass, one way or the other, so the interface tells no lies. The catalog entry components-disclosure-toggle-group/with-labels.json follows the chosen direction. Class-level sibling: #4631 (three-surface reconciliation instrument) — this card is one measured instance and does not wait for it.

---

Generated by Claude Code

[yinlianghui]

Claim: PM loop round 2
Session: session_01RnQd8iMMUwXQEV1crFmQiQ
Branch: claude/issue-4632-togglegroup-icon
Worktree: objectui-issue-4632
Domain: repo:objectui
File surface: packages/types/src/disclosure.ts + packages/components/src/renderers/disclosure/toggle-group.tsx (+ src/ui/toggle-group.tsx if implicated) + examples/schema-catalog/src/schemas/components-disclosure-toggle-group/with-labels.json + tests (stop on breach; explain in the report)
Container & model: S–M, mode:subagent, model: opus
Serial constraints cleared: in-flight #4649 also touches packages/types but in the list-view schema region (region-disjoint, named in its claim); #4650 touches plugin props files (disjoint); catalog surface: #4637 (index generator) is MERGED — a contents-only entry edit does not require regeneration (per that PR's own model), and #4627 (calendar entries) is queued but not in flight; no open dev PR touches these files (checked this round).

---

Generated by Claude Code