Analytics label net: the fetch-and-memo glue is written twice (DatasetWidget + plugin-report's useDatasetDimensionLabels) — its home is @object-ui/core

[yinlianghui]

Observation-class finding from PR #4388 (#4330). Nothing a user hits today — both copies call the same helpers and are pinned to the same behaviour on both surfaces. Filing so the duplication is retired deliberately rather than discovered later as drift.

What is duplicated, and what is not

The resolution rules are not duplicated: both surfaces call the same @object-ui/core helpers, which is the "one channel, no second dialect" property #4324 established and #4330 kept —

resolveDimensionFieldMeta → localizeFieldOptions / buildDimensionLabelMap → relabelDimensions

with the translator bound to useSafeFieldLabel().fieldOptionLabel.

What is written twice is the React glue around them — read the object schema through SchemaRendererContext.apiFetch (falling back to the global fetch), keep the fetched metadata locale-free in state, derive the label maps in a render memo so a language switch relabels in place instead of refetching:

• packages/plugin-dashboard/src/DatasetWidget.tsx — the resolution effect plus its { categoryColors, dimensionLabels, categoryOrder } memo;
• packages/plugin-report/src/useDatasetDimensionLabels.ts — the same shape, minus the chart-only colour/order wiring.

Why it was written twice

packages/core was held by #4040 tranche 5 while #4330 was in flight, and #4330's surface was the two plugin packages. The hook's file header says this and points here.

Suggested direction (for triage, not a decision)

Once tranche 5 lands, lift the glue into @object-ui/core beside the helpers it calls — one hook both plugins consume, with the dashboard keeping its extra colour/order derivation on top. Two details a mover should not lose, both of them bug fixes that are currently expressed twice:

• the read must ride the host's authenticated apiFetch (DatasetWidget's option-color / dimension-label probe reads the global fetch, bypassing the host's apiFetch channel (the plugin-dashboard twin of #4114) #4121), not the global fetch;
• the fetched metadata must stay locale-free in state (Analytics surfaces resolve select-option labels but never apply the i18n bundle — reports and dashboards show English while lists and forms show the translation #4030 / PR fix(core,plugin-dashboard,plugin-charts): run resolved select-option labels through the i18n bundle on analytics surfaces (#4030) #4324) — putting the locale in the effect's deps reintroduces a refetch on every language switch.

Both are pinned on the dashboard side; the report side would inherit them from the shared hook instead of restating them.

[yinlianghui]

CLAIM — PM seat session_017Qqyix2QcnpUC9XeYVDzx3, branch claude/issue-4389-label-net-glue-core, one dev agent, one PR, Fixes #4389. finding → pm:queue, promoted now because both of its gates cleared today: tranche 5 landed (core free) and PR #4388 (which created the second copy) is ready + auto-merge-armed.

Ruling: the card's suggested direction is adopted — lift the fetch-and-memo glue into @object-ui/core beside the helpers it calls; one hook both plugins consume; the dashboard keeps its chart-only colour/order derivation layered on top. The two bug-fix properties become singly-expressed and stay pinned: the read rides the host's authenticated apiFetch (#4121), and fetched metadata stays locale-free in state (#4030/#4324 — no locale in the effect deps). The existing pins on both surfaces keep passing unchanged as the refactor's acceptance evidence.

Dispatch gate: branch only after PR #4388 is in origin/main (polling instruction in the brief).

---

Generated by Claude Code

[yinlianghui]

PM RULING #2 (delegated authority, session session_017Qqyix2QcnpUC9XeYVDzx3; veto window open as always) — the original ruling's home designation is corrected by measurement, and the dispatch resumes under option A+B from the stop-report:

• The stop was correct. @object-ui/core cannot host the hook: @object-ui/react depends on core (importing back is a cycle), and core is React-free by declaration, content, and AGENTS.md §3 — the layering toPredicateInput 仍有两份实现(core canonical / react 渲染器侧),应让 react 直接 re-export core #3367 already ruled in exactly this direction (core-canonical logic, react re-exports; never core importing react). The issue title's "its home is @object-ui/core" is hereby retired as disproven.
• Adopted: A+B.
  • B half: the React-free parts (schema-load composition + label-map derivation over the existing resolveDimensionFieldMeta/localizeFieldOptions/relabelDimensions) extract into @object-ui/core beside the helpers — honoring the original ruling's intent within the layer that can hold it.
  • A half: the thin shared hook (useDatasetDimensionLabels or similar) lands in @object-ui/react beside useViewData/useElementDataSource/useDiscovery — the measured precedent that react already hosts this exact fetch-and-memo-off-apiFetch shape three times over. The domain-widening cost is accepted on that evidence: the analytics vocabulary lives in types imported from core either way, and the two load-bearing properties (DatasetWidget's option-color / dimension-label probe reads the global fetch, bypassing the host's apiFetch channel (the plugin-dashboard twin of #4114) #4121 apiFetch IN the effect deps; Analytics surfaces resolve select-option labels but never apply the i18n bundle — reports and dashboards show English while lists and forms show the translation #4030/fix(core,plugin-dashboard,plugin-charts): run resolved select-option labels through the i18n bundle on analytics surfaces (#4030) #4324 locale OUT of them) become singly-expressed in one hook — the drift surface this card names, actually closed.
• C (new package) rejected: a publishable package for one hook with two consumers is speculative surface, against the startup-focus principle.
• Unchanged from the original ruling: plugin-report's file becomes a thin re-export (preserving its rationale header and stable import path), DatasetWidget layers chart-only colour/order locally, all 39 fix(dashboard,report): localize a LOCAL select dimension on table/pivot and the dataset report block (#4330) #4388 pins pass UNCHANGED as acceptance evidence, changeset patch (now 4 packages), never major.
• Phantom dependency: react resolves from packages/core although core declares none — a resolution-based layering check returns the wrong answer #4394 (the phantom-dependency false-GREEN trap that would have hidden this cycle from a resolution-based check) is a valuable catch — stays in the finding pool.

---

Generated by Claude Code