`combo` dashboard widgets render as grouped bars — DatasetWidget has no `combo` family and refuses to forward `series`/`xAxis`/`yAxis` on the dataset path

[huangyiirene]

Symptom

A dashboard widget authoring a genuine combo chart:

chartConfig.series = [
  { name: 'task_count',   type: 'bar',  yAxis: 'left'  },
  { name: 'avg_progress', type: 'line', yAxis: 'right' },
]

plus two yAxis entries renders as two bar series on one shared 0–100 axis. Measured in the DOM:

Selector	Observed	Expected
.recharts-bar	2	1
.recharts-bar-rectangle	4	—
.recharts-line-curve	0	1
.recharts-yAxis	1	2

So the authored per-series type and the left/right axis split are both silently dropped: a bar-and-line dual-axis chart degrades into a grouped bar chart, and avg_progress (a 0–100 percentage) is plotted against the same axis as task_count (a raw count).

Reproduced 3× on independent fresh browser launches.

Not a stale-bundle artifact — verified against objectui origin/main, which is 138 commits ahead of the vendored pin (09987b68), and it behaves identically.

Root cause

Source-confirmed, and it is two halves, both in plugin-dashboard/src/DatasetWidget.tsx:

1. No combo family. The widget resolves the chart family with CHART_TYPE_MAP[widgetType] ?? 'bar', and CHART_TYPE_MAP has no combo entry — so combo falls through to the 'bar' default. That alone explains bars-not-lines.
2. The series are never forwarded. chartConfigPresentation() in the same file deliberately does not forward series / xAxis / yAxis on the ADR-0021 dataset path, on the stated grounds that "they are DERIVED from the dataset selection". So even with a combo entry added, the authored per-series type and axis binding could never reach the renderer.

The design tension this exposes (worth a decision before someone patches half of it)

widgetDispatch.ts on origin/main routes combo as a SERIES_CHART_TYPES member, commenting that "the chart renderer has always drawn it (it derives the base family from the series)".

That is exactly the contradiction: the dispatch layer's justification for combo needing no special handling is that the renderer derives the family from series — but on the dataset path series is precisely what DatasetWidget refuses to forward. The two halves of the codebase hold opposite beliefs about who owns series on the dataset path. Fixing only half (adding a CHART_TYPE_MAP.combo entry) yields a chart that is nominally a combo but still has no line and one axis; fixing only the other half (forwarding series) collides with the "derived from dataset selection" invariant. Please settle which layer owns it, then fix both sides consistently.

Untested caveat recorded in the same run

kpi / gauge / solid-gauge / bullet all render value-only — pixel-identical to metric. No dial, no arc, no bullet target band was drawn for any of them. This was recorded as an honest caveat, not ticked as passing and not separately reproduced; it may be the same "no entry in the family map" shape or may be four distinct gaps. Worth a look while this file is open.

The other 19 chart variants pass with mark counts reconciled against API buckets, and compareTo renders its comparison series correctly.

Reproduction

1. Boot the showcase (framework a86db175, vendored console 09987b68).
2. Open /_console/apps/com.example.showcase/dashboard/showcase_chart_gallery.
3. Wait for the loader to appear then clear, and let the board settle.
4. Inside the "Task Count vs Avg Progress" card (widget combo_count_vs_progress), count .recharts-bar, .recharts-bar-rectangle, .recharts-line-curve, .recharts-yAxis.
5. Observe 2 / 4 / 0 / 1 against the expected 1 / — / 1 / 2. Reproduced 3×.

Re-check the two source halves:

rg -n "CHART_TYPE_MAP|chartConfigPresentation" plugin-dashboard/src/DatasetWidget.tsx
rg -n "SERIES_CHART_TYPES|combo" src/**/widgetDispatch.ts

Related

Possibly a regression of — or unfinished follow-through on — #2880 (closed completed by #2883, "ObjectChart honors the spec ChartConfig author shape"). That issue's S2 explicitly scoped dual axes as yAxis[].position + series[].yAxis: 'left'|'right', noting "combo 目前按 series 类型隐式分配,改为显式绑定优先" — the exact binding that is inert here. #2880 landed the normalisation in ObjectChart; the dataset path through DatasetWidget appears never to have been carried over, which is consistent with what this run measured.

Source

Extracted from the QA run objectstack-ai/objectstack#7515 (framework a86db175). Checklist item chart-type-matrix.

[yinlianghui]

CLAIM + 代决 — session session_017Qqyix2QcnpUC9XeYVDzx3(objectui whole-repo PM seat;以产品长期稳定角度代决,否决窗口开放)。Branch: claude/issue-4229-combo-dataset-path。

卡片要求先裁的问题——dataset 路径上 series 归谁——裁:数据归 dataset,呈现归作者(merge-forward),锚定 #2880/S2 已裁的显式绑定优先:

1. "derived from the dataset selection" 不变量只正确地覆盖数据形状(哪些字段成为 series、行与桶),不覆盖呈现属性。per-series type、series[].yAxis: 'left'|'right'、yAxis[] 轴定义是作者意图,ObjectChart：兑现 ChartConfig 作者形状（type / xAxis.field / yAxis[].field / series[].name）与轴表现属性（framework#3701 对齐） #2880 已裁 ObjectChart 尊重它们;dataset 路径从未接续,正是本缺陷。
2. 执行形状:dataset 路径继续推导 series 成员列表;作者 chartConfig 中按 name/key 匹配到推导 series 的呈现属性合并其上(显式绑定优先,ObjectChart：兑现 ChartConfig 作者形状（type / xAxis.field / yAxis[].field / series[].name）与轴表现属性（framework#3701 对齐） #2880 S2 延伸到 dataset 路径)。作者条目点名 dataset 选择之外的度量 ⇒ 忽略(成员归 dataset);推导出而作者未配的 series ⇒ 保持家族默认。轴(yAxis[] 双轴)与 xAxis 呈现属性同规则转发。
3. CHART_TYPE_MAP 补 combo 条目,家族语义与 renderer 既有 combo(由 series 派生基族)一致。两半必须同 PR 一致落地——卡片已警告单修任一半都是坏状态。
4. kpi/gauge/solid-gauge/bullet 的 caveat 不入本卡范围:趁文件打开做低成本测量并以 finding 记录(可能是同形状 map 缺口也可能是四个独立缺陷),不顺手修。

Surface:plugin-dashboard/src/DatasetWidget.tsx(chartConfigPresentation + CHART_TYPE_MAP)+ 测试;ObjectChart / widgetDispatch 只读。无在飞持有者(#4273/#4275 已落,#4040 批次2 排除 plugin-dashboard)。

---

Generated by Claude Code

[yinlianghui]

ACCEPT — PM review of record (session session_017Qqyix2QcnpUC9XeYVDzx3)。

PR #4298 按裁决(数据归 dataset、呈现归作者,merge-forward)落地,验收要点:

• 合并语义以结构表达而非守卫:唯一的 mergeAuthoredPresentation 调用一次;数据/呈现分界走"减法"(ChartSeries 减 name、ChartAxis 减 field)——去掉 field 正是删掉作者轴能点名 series 的唯一通道,成员归属由构造保证而不是靠检查。这比逐调用点白名单强一个量级。
• combo: 'combo' 自映射有据(renderer 独立绘制 + spec rc.1 成员 + widgetDispatch 已解析为 combo),两半一 PR,两面信念收敛。
• 两个防新错的连带判断都对:compareTo overlay 继承主 measure 的 mark+axis(否则本修复自己会制造"对比期画成右轴线"的新错),且只继承 mark/axis 绝不继承 stack(避免两期求和);per-series type 收窄到 bar/line/area 镜像 normalizeSeries(防内部形状数组绕过 renderer 收窄,type:'pie' 不是惰性的——会翻家族)。
• 红先 8/4 与预言精确一致;4 个双侧绿的对照 pin(选择外 series 忽略、非笛卡尔 type 丢弃、无 chartConfig 字节不变、纯 chrome 不动绑定)正是裁决的边界条款。
• DOM 表未在本包重测的声明诚实且已跨文件对账(recharts 只在 plugin-charts 可解析,mark 半场已由 AdvancedChartImpl 的既有 pin 覆盖本 PR 发射的形状)。
• fix(dashboard): resolve a dotted dimension's labels on table and pivot dataset widgets #4273/fix(dashboard,report): encode an empty pivot dimension value as JSON null, not a placeholder string #4275 区域零扰动;CI 20 项收敛全绿。
• gauge 族测量结论正确:same-shape 且有意为之(spec 自述"诚实的单值变体、等真 dial renderer",Tier 2 (#2901): spec values that validate and then render nothing #2942 特意迁移)——不是 combo dashboard widgets render as grouped bars — DatasetWidget has no combo family and refuses to forward series/xAxis/yAxis on the dataset path #4229 的缺失映射形状,gauge / solid-gauge / bullet / kpi all render as a plain number — one missing dial/target renderer, deliberately shared by four spec chart types #4295 以 observation 级记录,不入队。处理得当。

Flipping ready + auto-merge。

---

Generated by Claude Code