docs(app-shell): rewrite three docblocks this branch falsified (#3666)

The two sidebars' `sys-datasources` entry now names the canonical
`…/metadata/datasource` route, so three comments claiming the setup left-nav
points at the legacy alias became false as of the previous commit.

Rewritten as positive statements of what is true now. Per #3656, none of them
re-plants the alias URL in a denial sentence — a comment that says "no longer
points at X" keeps a grep for X returning the very hit the rewrite was meant
to clear.

`console/AppContent.tsx` is a comment-only change: the two alias route
declarations, and every other line of code, are untouched. Its #3610 history
is preserved and extended rather than replaced — #3610 declined to re-point
the navigation because a zero-app-only spelling would have given the alias a
second canonical destination, and #3660 re-pointed it at the shared route, so
that reasoning still holds.

Fixes #3666

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt

Author: claude

packages/app-shell/src/console/AppContent.tsx

@@ -646,16 +646,19 @@ export function AppContent({ extraRoutes, extraRoutesNoApp }: AppContentProps =
               branch below. They are NOT a second copy of the page: both render
               `LegacyMetadataRedirect`, which forwards onto the canonical
               `metadata/:type…` routes declared just above. Declaring them here
-              is what makes the zero-app console's own fallback navigation work:
-              `sys-datasources` points straight at
-              `…/component/metadata/resource?type=datasource`, and `sys-objects`
-              arrives via the host's `system/metadata/:type` → same alias
-              rewrite. Both pass `isMetadataRoute` (a `metadata` path segment —
-              a substring test until #3638) and so land in THIS branch, which declared no
-              `component/…` route at all — every one of them rendered a blank
-              screen. Kept as a mirror rather than re-pointed navigation because
-              the alias already has exactly one canonical destination; adding a
-              zero-app-only spelling would create a second. */}
+              is what stopped the zero-app console rendering a blank screen: the
+              fallback navigation then aimed `sys-datasources` at an alias, and
+              carried `sys-objects` onto one via the host's
+              `system/metadata/:type` rewrite. Both pass `isMetadataRoute` (a
+              `metadata` path segment — a substring test until #3638) and so land
+              in THIS branch, which declared no `component/…` route at all —
+              every one of them rendered a blank screen. #3610 mirrored the
+              routes rather than re-point that navigation, because inventing a
+              zero-app-only spelling would have given the alias a second
+              canonical destination. #3660 re-pointed it anyway — at the shared
+              `metadata/:type` routes above, so no second spelling was created —
+              which leaves these two serving bookmarks and external links, the
+              arrivals that can never be re-pointed. */}
           <Route path="component/metadata/directory" element={<LegacyMetadataRedirect mode="directory" />} />
           <Route path="component/metadata/resource/*" element={<LegacyMetadataRedirect mode="resource" />} />
           {extraRoutesNoApp}

packages/app-shell/src/views/metadata-admin/datasource/DatasourceResourcePage.tsx

@@ -5,11 +5,12 @@
  * registered into the metadata-admin engine (`registerMetadataResource`) and
  * reached via the engine route `…/metadata/datasource`.
  *
- * Two legacy spellings still arrive here, both as redirects onto that engine
- * route rather than routes of their own (objectui#3639): the setup left-nav
- * "Datasources" item points at `…/component/metadata/resource?type=datasource`
- * (rewritten by `LegacyMetadataRedirect`), and the console host forwards
- * `…/system/metadata/datasource` (rewritten by its own `MetadataRedirect`).
+ * The setup left-nav "Datasources" item names that engine route directly
+ * (objectui#3660). Two legacy spellings still arrive here as well, both as
+ * redirects onto the same engine route rather than routes of their own: the
+ * console host forwards `…/system/metadata/datasource` (rewritten by its own
+ * `MetadataRedirect`), and the older aliases `AppContent` declares for
+ * bookmarks and external links are rewritten by `LegacyMetadataRedirect`.
  *
  * datasource is a *side-effectful* metadata type: its records are managed by
  * the framework `datasource-admin` service (secret encryption + connection-pool

packages/app-shell/src/views/metadata-admin/datasource/register.ts

@@ -8,10 +8,11 @@
  * (engine route + registry slot + shell), reachable at the engine route
  * `…/metadata/datasource`, instead of a separate hand-written System page.
  *
- * The setup left-nav "Datasources" item still points at the older
- * `…/component/metadata/resource?type=datasource` spelling. That is a legacy
- * *alias*, not this engine route: it renders `LegacyMetadataRedirect`, which
- * 302s onto `…/metadata/datasource` (objectui#3639).
+ * The setup left-nav "Datasources" item names that engine route directly
+ * (objectui#3660). The older alias spellings `AppContent` still declares are
+ * redirects onto it rather than routes of their own — kept so bookmarks and
+ * external links keep resolving — but no navigation in this repo is routed
+ * through them any more.
  */
 
 import { registerMetadataResource } from '../registry';